From: David Miller <davem@davemloft.net>
To: dkirjanov@kernel.org
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
bhutchings@solarflare.com
Subject: Re: [PATCH -next] sundance: Add initial ethtool stats support
Date: Tue, 12 Oct 2010 11:51:38 -0700 (PDT) [thread overview]
Message-ID: <20101012.115138.112614145.davem@davemloft.net> (raw)
In-Reply-To: <4CB0C56C.2000106@kernel.org>
From: Denis Kirjanov <dkirjanov@kernel.org>
Date: Sat, 09 Oct 2010 23:41:32 +0400
> + /* ethtool extra stats */
> + struct {
> + unsigned long tx_multiple_collisions;
> + unsigned long tx_single_collisions;
> + unsigned long tx_late_collisions;
> + unsigned long tx_deffered;
> + unsigned long tx_deffered_excessive;
> + unsigned long tx_aborted;
> + unsigned long tx_bcasts;
> + unsigned long rx_bcasts;
> + unsigned long tx_mcasts;
> + unsigned long rx_mcasts;
> + } xstats;
I think these should be "u64".
next prev parent reply other threads:[~2010-10-12 18:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-09 9:53 [PATCH -next] sundance: Add initial ethtool stats support Denis Kirjanov
2010-10-09 12:17 ` [PATCH net-next] sundance: get_stats proper locking Eric Dumazet
2010-10-09 16:24 ` David Miller
2010-10-09 12:33 ` [PATCH -next] sundance: Add initial ethtool stats support Eric Dumazet
2010-10-09 13:27 ` Ben Hutchings
2010-10-09 14:40 ` Denis Kirjanov
2010-10-09 19:41 ` Denis Kirjanov
2010-10-09 21:48 ` Jeff Garzik
2010-10-12 18:51 ` David Miller [this message]
2010-10-12 20:36 ` Denis Kirjanov
2010-10-12 20:57 ` Joe Perches
2010-10-13 6:06 ` Denis Kirjanov
2010-10-13 6:33 ` Eric Dumazet
2010-10-13 7:02 ` Denis Kirjanov
2010-10-13 10:28 ` Denis Kirjanov
2010-10-13 10:36 ` Eric Dumazet
2010-10-13 10:56 ` Denis Kirjanov
2010-10-13 19:44 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101012.115138.112614145.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=dkirjanov@kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).