From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: dmitry@broadcom.com, netdev@vger.kernel.org,
eric.dumazet@gmail.com, vladz@broadcom.com, eilong@broadcom.com
Subject: Re: [PATCH net-next] bnx2x: Fixing a typo: added a missing RSS enablement
Date: Tue, 12 Oct 2010 12:31:42 -0700 (PDT) [thread overview]
Message-ID: <20101012.123142.59664847.davem@davemloft.net> (raw)
In-Reply-To: <1286911579.1117.76.camel@Joe-Laptop>
From: Joe Perches <joe@perches.com>
Date: Tue, 12 Oct 2010 12:26:19 -0700
> On Tue, 2010-10-12 at 21:02 +0200, Dmitry Kravkov wrote:
>> @@ -2486,6 +2486,7 @@ void bnx2x_pf_init(struct bnx2x *bp)
>> * if (is_eth_multi(bp))
>> * flags |= FUNC_FLG_RSS;
>> */
>> + flags |= FUNC_FLG_RSS;
>>
>> /* function setup */
>> if (flags & FUNC_FLG_RSS) {
>
> Then the "if (flags & FUNC_FLG_RSS)" test should be removed.
Yeah it probably should. If necessary it could be added back
later.
next prev parent reply other threads:[~2010-10-12 19:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 19:02 [PATCH net-next] bnx2x: Fixing a typo: added a missing RSS enablement Dmitry Kravkov
2010-10-12 19:18 ` Eric Dumazet
2010-10-12 19:31 ` David Miller
2010-10-12 19:26 ` Joe Perches
2010-10-12 19:31 ` David Miller [this message]
2010-10-12 20:08 ` Vladislav Zolotarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101012.123142.59664847.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=vladz@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).