* [-next Oct 13] Build failure drivers/s390/net/ctcm_mpc.o
@ 2010-10-13 15:09 Sachin Sant
2010-10-13 16:12 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Sachin Sant @ 2010-10-13 15:09 UTC (permalink / raw)
To: netdev; +Cc: linux-next@vger.kernel.org, linux-s390, ursula.braun,
Eric Dumazet
Today's next fails to build on a s390 box with following
error
drivers/s390/net/ctcm_mpc.c: In function ctc_mpc_dealloc_ch:
drivers/s390/net/ctcm_mpc.c:541: error: struct net_device has no member named refcnt
The code in question was changed by
commit 29b4433d991c88d86ca48a4c1cc33c671475be4b
net: percpu net_device refcount
The net_device struct member refcnt was changed from atomic_t to
int __percpu.
Thanks
-Sachin
--
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [-next Oct 13] Build failure drivers/s390/net/ctcm_mpc.o
2010-10-13 15:09 [-next Oct 13] Build failure drivers/s390/net/ctcm_mpc.o Sachin Sant
@ 2010-10-13 16:12 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-10-13 16:12 UTC (permalink / raw)
To: sachinp; +Cc: netdev, linux-next, linux-s390, ursula.braun, eric.dumazet
From: Sachin Sant <sachinp@in.ibm.com>
Date: Wed, 13 Oct 2010 20:39:16 +0530
> Today's next fails to build on a s390 box with following
> error
>
> drivers/s390/net/ctcm_mpc.c: In function ctc_mpc_dealloc_ch:
> drivers/s390/net/ctcm_mpc.c:541: error: struct net_device has no
> member named refcnt
This should fix it:
--------------------
s390: ctcm_mpc: Fix build after netdev refcount changes.
Reported-by: Sachin Sant <sachinp@in.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
drivers/s390/net/ctcm_mpc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/s390/net/ctcm_mpc.c b/drivers/s390/net/ctcm_mpc.c
index 2861e78..b64881f 100644
--- a/drivers/s390/net/ctcm_mpc.c
+++ b/drivers/s390/net/ctcm_mpc.c
@@ -540,7 +540,7 @@ void ctc_mpc_dealloc_ch(int port_num)
CTCM_DBF_TEXT_(MPC_SETUP, CTC_DBF_DEBUG,
"%s: %s: refcount = %d\n",
- CTCM_FUNTAIL, dev->name, atomic_read(&dev->refcnt));
+ CTCM_FUNTAIL, dev->name, netdev_refcnt_read(dev));
fsm_deltimer(&priv->restart_timer);
grp->channels_terminating = 0;
--
1.7.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-13 16:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-13 15:09 [-next Oct 13] Build failure drivers/s390/net/ctcm_mpc.o Sachin Sant
2010-10-13 16:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).