* [PATCH net-next] fib: remove a useless synchronize_rcu() call
@ 2010-10-13 14:43 Eric Dumazet
2010-10-16 18:55 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2010-10-13 14:43 UTC (permalink / raw)
To: David Miller; +Cc: netdev
fib_nl_delrule() calls synchronize_rcu() for no apparent reason,
while rtnl is held.
I suspect it was done to avoid an atomic_inc_not_zero() in
fib_rules_lookup(), which commit 7fa7cb7109d07 added anyway.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
net/core/fib_rules.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c
index 21698f8..1bc3f25 100644
--- a/net/core/fib_rules.c
+++ b/net/core/fib_rules.c
@@ -494,7 +494,6 @@ static int fib_nl_delrule(struct sk_buff *skb, struct nlmsghdr* nlh, void *arg)
}
}
- synchronize_rcu();
notify_rule_change(RTM_DELRULE, rule, ops, nlh,
NETLINK_CB(skb).pid);
fib_rule_put(rule);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] fib: remove a useless synchronize_rcu() call
2010-10-13 14:43 [PATCH net-next] fib: remove a useless synchronize_rcu() call Eric Dumazet
@ 2010-10-16 18:55 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-10-16 18:55 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 13 Oct 2010 16:43:04 +0200
> fib_nl_delrule() calls synchronize_rcu() for no apparent reason,
> while rtnl is held.
>
> I suspect it was done to avoid an atomic_inc_not_zero() in
> fib_rules_lookup(), which commit 7fa7cb7109d07 added anyway.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-16 18:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-13 14:43 [PATCH net-next] fib: remove a useless synchronize_rcu() call Eric Dumazet
2010-10-16 18:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).