From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] netns: reorder fields in struct net
Date: Sun, 17 Oct 2010 13:49:31 -0700 (PDT) [thread overview]
Message-ID: <20101017.134931.183048950.davem@davemloft.net> (raw)
In-Reply-To: <1287071778.2712.73.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 14 Oct 2010 17:56:18 +0200
> In a network bench, I noticed an unfortunate false sharing between
> 'loopback_dev' and 'count' fields in "struct net".
>
> 'count' is written each time a socket is created or destroyed, while
> loopback_dev might be often read in routing code.
>
> Move loopback_dev in a read mostly section of "struct net"
>
> Note: struct netns_xfrm is cache line aligned on SMP.
> (It contains a "struct dst_ops")
> Move it at the end to avoid holes, and reduce sizeof(struct net) by 128
> bytes on ia32.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks Eric.
prev parent reply other threads:[~2010-10-17 20:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 15:56 [PATCH net-next] netns: reorder fields in struct net Eric Dumazet
2010-10-17 20:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101017.134931.183048950.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).