From: David Miller <davem@davemloft.net>
To: xiaohui.xin@intel.com
Cc: netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, mst@redhat.com, mingo@elte.hu,
herbert@gondor.apana.org.au, jdike@linux.intel.com
Subject: Re: [PATCH v13 10/16] Add a hook to intercept external buffers from NIC driver.
Date: Tue, 19 Oct 2010 08:24:01 -0700 (PDT) [thread overview]
Message-ID: <20101019.082401.28817543.davem@davemloft.net> (raw)
In-Reply-To: <33f51c5eddec843260451eccbfa3c5fdea13b479.1287132437.git.xiaohui.xin@intel.com>
From: xiaohui.xin@intel.com
Date: Fri, 15 Oct 2010 17:12:11 +0800
> @@ -2891,6 +2922,11 @@ static int __netif_receive_skb(struct sk_buff *skb)
> ncls:
> #endif
>
> + /* To intercept mediate passthru(zero-copy) packets here */
> + skb = handle_mpassthru(skb, &pt_prev, &ret, orig_dev);
> + if (!skb)
> + goto out;
> +
> /* Handle special case of bridge or macvlan */
> rx_handler = rcu_dereference(skb->dev->rx_handler);
> if (rx_handler) {
If you consume the packet here, devices in passthru mode cannot
be use with bonding.
But there is nothing that prevents a bond being created with such
a device.
So we have to either prevent such configurations (bad) or make
it work somehow (good) :-)
next prev parent reply other threads:[~2010-10-19 15:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 9:12 [PATCH v13 00/16] Provide a zero-copy method on KVM virtio-net xiaohui.xin
2010-10-15 9:12 ` [PATCH v13 01/16] Add a new structure for skb buffer from external xiaohui.xin
2010-10-15 9:12 ` [PATCH v13 02/16] Add a new struct for device to manipulate external buffer xiaohui.xin
2010-10-15 9:12 ` [PATCH v13 03/16] Add a ndo_mp_port_prep pointer to net_device_ops xiaohui.xin
2010-10-15 9:12 ` [PATCH v13 04/16] Add a function make external buffer owner to query capability xiaohui.xin
2010-10-15 9:12 ` [PATCH v13 05/16] Add a function to indicate if device use external buffer xiaohui.xin
2010-10-15 9:12 ` [PATCH v13 06/16]Use callback to deal with skb_release_data() specially xiaohui.xin
2010-10-15 9:12 ` [PATCH v13 07/16] Modify netdev_alloc_page() to get external buffer xiaohui.xin
2010-10-15 9:12 ` [PATCH v13 08/16] Modify netdev_free_page() to release " xiaohui.xin
2010-10-15 9:12 ` [PATCH v13 09/16]Don't do skb recycle, if device use " xiaohui.xin
2010-10-15 9:12 ` [PATCH v13 10/16] Add a hook to intercept external buffers from NIC driver xiaohui.xin
2010-10-19 15:24 ` David Miller [this message]
2010-10-27 1:33 ` Xin, Xiaohui
2010-10-29 20:28 ` David Miller
2010-11-08 7:43 ` Xin, Xiaohui
2010-10-15 9:12 ` [PATCH v13 11/16] Add header file for mp device xiaohui.xin
2010-10-15 9:12 ` [PATCH v13 12/16] Add mp(mediate passthru) device xiaohui.xin
2010-10-15 9:12 ` [PATCH v13 13/16] Add a kconfig entry and make entry for mp device xiaohui.xin
2010-10-15 9:12 ` [PATCH v13 14/16]Provides multiple submits and asynchronous notifications xiaohui.xin
2010-10-15 9:12 ` [PATCH v13 15/16] An example how to modifiy NIC driver to use napi_gro_frags() interface xiaohui.xin
2010-10-15 9:12 ` [PATCH v13 16/16] An example how to alloc user buffer based on " xiaohui.xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019.082401.28817543.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jdike@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=xiaohui.xin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).