From: David Miller <davem@davemloft.net>
To: bandan.das@stratus.com
Cc: shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [PATCH] bridge: make br_parse_ip_options static
Date: Thu, 21 Oct 2010 03:12:35 -0700 (PDT) [thread overview]
Message-ID: <20101021.031235.112594832.davem@davemloft.net> (raw)
In-Reply-To: <20101019112234.GB12005@stratus.com>
From: Bandan Das <bandan.das@stratus.com>
Date: Tue, 19 Oct 2010 07:22:34 -0400
> On 0, Stephen Hemminger <shemminger@vyatta.com> wrote:
>>
>> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>>
>> --- a/net/bridge/br_netfilter.c 2010-10-18 17:01:36.903364885 -0700
>> +++ b/net/bridge/br_netfilter.c 2010-10-18 17:01:48.106569141 -0700
>> @@ -213,7 +213,7 @@ static inline void nf_bridge_update_prot
>> * expected format
>> */
>>
>> -int br_parse_ip_options(struct sk_buff *skb)
>> +static int br_parse_ip_options(struct sk_buff *skb)
>> {
>> struct ip_options *opt;
>> struct iphdr *iph;
>>
>
> My main motivation behind not making this static was that
> there would be possibly other places in the bridge code
> (besides br_netfilter.c) where we enter the IP stack and might
> want to call this. Not sure if it's indeed the case though..
You can un-static it when the use is added.
Patch applied, thanks Stephen.
prev parent reply other threads:[~2010-10-21 10:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 0:03 [PATCH] bridge: make br_parse_ip_options static Stephen Hemminger
2010-10-19 11:22 ` Bandan Das
2010-10-19 14:55 ` Stephen Hemminger
2010-10-19 16:03 ` Bandan Das
2010-10-21 10:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021.031235.112594832.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bandan.das@stratus.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).