From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, bphilips@novell.com,
eric.dumazet@gmail.com, donald.c.skidmore@intel.com
Subject: Re: [net-next-2.6 PATCH 2/3] ixgbe: fix stats handling
Date: Thu, 21 Oct 2010 03:56:03 -0700 (PDT) [thread overview]
Message-ID: <20101021.035603.233701260.davem@davemloft.net> (raw)
In-Reply-To: <20101021090001.12059.37088.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 21 Oct 2010 02:00:04 -0700
> From: Eric Dumazet <eric.dumazet@gmail.com>
>
> Current ixgbe stats have following problems :
>
> - Not 64 bit safe (on 32bit arches)
>
> - Not safe in ixgbe_clean_rx_irq() :
> All cpus dirty a common location (netdev->stats.rx_bytes &
> netdev->stats.rx_packets) without proper synchronization.
> This slow down a bit multiqueue operations, and possibly miss some
> updates.
>
> Fixes :
>
> Implement ndo_get_stats64() method to provide accurate 64bit rx|tx
> bytes/packets counters, using 64bit safe infrastructure.
>
> ixgbe_get_ethtool_stats() also use this infrastructure to provide 64bit
> safe counters.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Acked-by: Don Skidmore <donald.c.skidmore@intel.com>
> Tested-by: Stephen Ko <stephen.s.ko@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
next prev parent reply other threads:[~2010-10-21 10:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 8:59 [net-next-2.6 PATCH 1/3] ixgbe: update copyright info Jeff Kirsher
2010-10-21 9:00 ` [net-next-2.6 PATCH 2/3] ixgbe: fix stats handling Jeff Kirsher
2010-10-21 10:56 ` David Miller [this message]
2010-10-21 9:00 ` [net-next-2.6 PATCH 3/3] ixgbe: add a refcnt when turning on/off FCoE offload capability Jeff Kirsher
2010-10-21 10:56 ` David Miller
2010-10-21 10:55 ` [net-next-2.6 PATCH 1/3] ixgbe: update copyright info David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021.035603.233701260.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bphilips@novell.com \
--cc=donald.c.skidmore@intel.com \
--cc=eric.dumazet@gmail.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).