From: David Miller <davem@davemloft.net>
To: james@albanarts.com
Cc: zambrano@broadcom.com, jpirko@redhat.com,
fujita.tomonori@lab.ntt.co.jp, hauke@hauke-m.de,
Larry.Finger@lwfinger.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH v2] b44: fix resume, request_irq after hw reset
Date: Thu, 21 Oct 2010 04:30:36 -0700 (PDT) [thread overview]
Message-ID: <20101021.043036.57469867.davem@davemloft.net> (raw)
In-Reply-To: <201010171249.00485.james@albanarts.com>
From: James Hogan <james@albanarts.com>
Date: Sun, 17 Oct 2010 12:48:59 +0100
> On resume, call request_irq() after resetting the hardware rather than
> before. It's a shared interrupt so the handler could be called
> immediately if another device on the same irq interrupts (and will be
> called immediately if CONFIG_DEBUG_SHIRQ=y), but unless the hardware is
> reinitialised with b44_init_hw() the read of the interrupt status
> register will hang the system.
>
> Signed-off-by: James Hogan <james@albanarts.com>
Applied.
prev parent reply other threads:[~2010-10-21 11:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-17 11:48 [PATCH v2] b44: fix resume, request_irq after hw reset James Hogan
2010-10-21 11:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021.043036.57469867.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Larry.Finger@lwfinger.net \
--cc=akpm@linux-foundation.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hauke@hauke-m.de \
--cc=james@albanarts.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).