From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 2/2] can: mcp251x: fix generation of error frames Date: Thu, 21 Oct 2010 04:33:06 -0700 (PDT) Message-ID: <20101021.043306.149829565.davem@davemloft.net> References: <1287568946-32727-1-git-send-email-mkl@pengutronix.de> <1287568946-32727-3-git-send-email-mkl@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org Return-path: In-Reply-To: <1287568946-32727-3-git-send-email-mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org From: Marc Kleine-Budde Date: Wed, 20 Oct 2010 12:02:26 +0200 > The function "mcp251x_error_skb" is used to generate error frames. > They are identified by the "CAN_ERR_FLAG" in can_id. The function > overwrites the can_id so that the frames show up as normal frames instead > of error frames. > > This patch fixes the problem by or'ing the can_id instead of overwriting it. > > Signed-off-by: Marc Kleine-Budde > Tested-by: Jargalan Nermunkh Applied.