netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: rcj@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ibmveth: Increase default copybreak limits to 2k
Date: Thu, 21 Oct 2010 07:45:25 -0700 (PDT)	[thread overview]
Message-ID: <20101021.074525.71113963.davem@davemloft.net> (raw)
In-Reply-To: <20101021143753.GA5567@linux.vnet.ibm.com>

From: Robert Jennings <rcj@linux.vnet.ibm.com>
Date: Thu, 21 Oct 2010 09:37:53 -0500

> Increase the copybreak limits for rx and tx from 128 bytes
> to 2048 bytes. These limits were added by commits
> 8d86c61ae41d9068fd5e5cc01a4abd53c4fe3ab5 and
> c08cc3ccebd46dce44d13a8ce81d249e687eeb8a to make use of a
> bounce buffer for packets below 128 bytes.  This avoids
> tearing down and creating a TCE entry.
> 
> Performance testing shows that this default limit can be
> increased from 128 to 2048 for both rx and tx copybreak.
> This resulted in ~10% throughput increase for for packets
> that fit this limit without affecting performance for larger
> packets.
> 
> Signed-off-by: Robert Jennings <rcj@linux.vnet.ibm.com>

For a default MTU of 1500 this means the copybreak will
never be used.

This makes absolutely no sense, are you doing these tests
with Jumbo frames?

  reply	other threads:[~2010-10-21 14:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-21 14:37 [PATCH] ibmveth: Increase default copybreak limits to 2k Robert Jennings
2010-10-21 14:45 ` David Miller [this message]
2010-10-21 15:17   ` Robert Jennings
2010-10-24 22:40     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101021.074525.71113963.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=rcj@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).