From: John Fastabend <john.r.fastabend@intel.com>
To: netdev@vger.kernel.org
Cc: jesse@nicira.com
Subject: [RFC][net-next-2.6 PATCH 4/4] net: remove check for headroom in vlan_dev_create
Date: Thu, 21 Oct 2010 15:10:20 -0700 [thread overview]
Message-ID: <20101021221020.22906.96059.stgit@jf-dev1-dcblab> (raw)
In-Reply-To: <20101021221004.22906.58438.stgit@jf-dev1-dcblab>
It is possible for the headroom to be smaller then the
hard_header_len for a short period of time after toggling
the vlan offload setting.
This is not a hard error and skb_cow_head is called in
__vlan_put_tag() to resolve this.
Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
---
net/8021q/vlan_dev.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index 1645c3c..e043389 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -238,9 +238,6 @@ static int vlan_dev_hard_header(struct sk_buff *skb, struct net_device *dev,
{
int rc;
- if (WARN_ON(skb_headroom(skb) < dev->hard_header_len))
- return -ENOSPC;
-
/* When this flag is not set we make the vlan_tci visible
* by setting the skb field.
*
next prev parent reply other threads:[~2010-10-21 22:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 22:10 [RFC][net-next-2.6 PATCH 1/4] net: consolidate 8021q tagging John Fastabend
2010-10-21 22:10 ` [RFC][net-next-2.6 PATCH 2/4] net: 8021Q consolidate header_ops routines John Fastabend
2010-10-25 22:44 ` Jesse Gross
2010-11-04 0:47 ` Jesse Gross
2010-11-04 13:43 ` John Fastabend
2010-11-04 18:26 ` Jesse Gross
2010-10-21 22:10 ` [RFC][net-next-2.6 PATCH 3/4] ethtool: set hard_header_len using ETH_FLAG_{TX|RX}VLAN John Fastabend
2010-10-22 13:00 ` Ben Hutchings
2010-10-25 22:45 ` Jesse Gross
2010-10-26 21:58 ` John Fastabend
2010-10-21 22:10 ` John Fastabend [this message]
2010-10-25 22:45 ` [RFC][net-next-2.6 PATCH 4/4] net: remove check for headroom in vlan_dev_create Jesse Gross
2010-10-26 22:05 ` John Fastabend
2010-10-27 2:07 ` Jesse Gross
2010-10-25 22:44 ` [RFC][net-next-2.6 PATCH 1/4] net: consolidate 8021q tagging Jesse Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021221020.22906.96059.stgit@jf-dev1-dcblab \
--to=john.r.fastabend@intel.com \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).