From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next-2.6 v1] can: Topcliff: Update PCH_CAN driver to 2.6.35 Date: Sun, 24 Oct 2010 14:55:37 -0700 (PDT) Message-ID: <20101024.145537.112602993.davem@davemloft.net> References: <4CB8506C.3060600@dsn.okisemi.com> <20101024.144312.104048720.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, margie.foster-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org, morinaga526-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org, joel.clark-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, chripell-VaTbYqLCNhc@public.gmane.org, qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org To: masa-korg-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org Return-path: In-Reply-To: <20101024.144312.104048720.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org Please send a patch against the current driver which will fix these build warnings that occur when CONFIG_PM is disabled: drivers/net/can/pch_can.c:258:13: warning: 'pch_can_set_int_custom' defined but not used drivers/net/can/pch_can.c:269:13: warning: 'pch_can_get_int_enables' defined but not used drivers/net/can/pch_can.c:420:13: warning: 'pch_can_get_rx_enable' defined but not used drivers/net/can/pch_can.c:438:13: warning: 'pch_can_get_tx_enable' defined but not used drivers/net/can/pch_can.c:462:13: warning: 'pch_can_set_rx_buffer_link' defined but not used drivers/net/can/pch_can.c:480:13: warning: 'pch_can_get_rx_buffer_link' defined but not used Thank you.