From: David Miller <davem@davemloft.net>
To: paul.gortmaker@windriver.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] pktgen: clean up handling of local/transient counter vars
Date: Sun, 24 Oct 2010 15:23:50 -0700 (PDT) [thread overview]
Message-ID: <20101024.152350.260093579.davem@davemloft.net> (raw)
In-Reply-To: <1287440084-4848-1-git-send-email-paul.gortmaker@windriver.com>
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Mon, 18 Oct 2010 18:14:44 -0400
> The temporary variable "i" is needlessly initialized to zero
> in two distinct cases in this file:
>
> 1) where it is set to zero and then used as an argument in an addition
> before being assigned a non-zero value.
>
> 2) where it is only used in a standard/typical loop counter
>
> For (1), simply delete assignment to zero and usages while still
> zero; for (2) simply make the loop start at zero as per standard
> practice as seen everywhere else in the same file.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Applied.
prev parent reply other threads:[~2010-10-24 22:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 22:14 [PATCH] pktgen: clean up handling of local/transient counter vars Paul Gortmaker
2010-10-24 22:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101024.152350.260093579.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).