* [PATCH] ip6_tunnel dont update the mtu on the route.
@ 2010-10-19 13:50 Anders.Franzen
2010-10-19 14:32 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Anders.Franzen @ 2010-10-19 13:50 UTC (permalink / raw)
To: eric.dumazet, netdev; +Cc: Anders Franzen
From: Anders Franzen <anders.franzen@ericsson.com>
The ip6_tunnel device did not unset the flag,
IFF_XMIT_DST_RELEASE. This will make the dev layer
to release the dst before calling the tunnel.
The tunnel will not update any mtu/pmtu info, since
it does not have a dst on the skb.
---
net/ipv6/ip6_tunnel.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c
index c2c0f89..38b9a56 100644
--- a/net/ipv6/ip6_tunnel.c
+++ b/net/ipv6/ip6_tunnel.c
@@ -1371,6 +1371,7 @@ static void ip6_tnl_dev_setup(struct net_device *dev)
dev->flags |= IFF_NOARP;
dev->addr_len = sizeof(struct in6_addr);
dev->features |= NETIF_F_NETNS_LOCAL;
+ dev->priv_flags &= ~IFF_XMIT_DST_RELEASE;
}
--
1.7.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ip6_tunnel dont update the mtu on the route.
2010-10-19 13:50 [PATCH] ip6_tunnel dont update the mtu on the route Anders.Franzen
@ 2010-10-19 14:32 ` Eric Dumazet
2010-10-24 22:24 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2010-10-19 14:32 UTC (permalink / raw)
To: Anders.Franzen; +Cc: netdev
Le mardi 19 octobre 2010 à 15:50 +0200, Anders.Franzen@ericsson.com a
écrit :
> From: Anders Franzen <anders.franzen@ericsson.com>
>
> The ip6_tunnel device did not unset the flag,
> IFF_XMIT_DST_RELEASE. This will make the dev layer
> to release the dst before calling the tunnel.
> The tunnel will not update any mtu/pmtu info, since
> it does not have a dst on the skb.
> ---
> net/ipv6/ip6_tunnel.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c
> index c2c0f89..38b9a56 100644
> --- a/net/ipv6/ip6_tunnel.c
> +++ b/net/ipv6/ip6_tunnel.c
> @@ -1371,6 +1371,7 @@ static void ip6_tnl_dev_setup(struct net_device *dev)
> dev->flags |= IFF_NOARP;
> dev->addr_len = sizeof(struct in6_addr);
> dev->features |= NETIF_F_NETNS_LOCAL;
> + dev->priv_flags &= ~IFF_XMIT_DST_RELEASE;
> }
>
>
Thanks for catching this Anders
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ip6_tunnel dont update the mtu on the route.
2010-10-19 14:32 ` Eric Dumazet
@ 2010-10-24 22:24 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-10-24 22:24 UTC (permalink / raw)
To: eric.dumazet; +Cc: Anders.Franzen, netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 19 Oct 2010 16:32:08 +0200
> Le mardi 19 octobre 2010 à 15:50 +0200, Anders.Franzen@ericsson.com a
> écrit :
>> From: Anders Franzen <anders.franzen@ericsson.com>
>>
>> The ip6_tunnel device did not unset the flag,
>> IFF_XMIT_DST_RELEASE. This will make the dev layer
>> to release the dst before calling the tunnel.
>> The tunnel will not update any mtu/pmtu info, since
>> it does not have a dst on the skb.
...
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
Anders, please provide a proper "Signed-off-by: " tag in your
commit messages in the future.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-24 22:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-19 13:50 [PATCH] ip6_tunnel dont update the mtu on the route Anders.Franzen
2010-10-19 14:32 ` Eric Dumazet
2010-10-24 22:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).