From: David Miller <davem@davemloft.net>
To: harvey.harrison@gmail.com
Cc: sbhatewara@vmware.com, netdev@vger.kernel.org, shemminger@vyatta.com
Subject: Re: [PATCH 3/3] vmxnet3: fix typo setting confPA
Date: Sun, 24 Oct 2010 15:44:17 -0700 (PDT) [thread overview]
Message-ID: <20101024.154417.116368884.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTimy5Pg1aUMfCZG+r+Zb=A_udx8NsYf3TXVHHTsf@mail.gmail.com>
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Fri, 22 Oct 2010 10:52:15 -0700
> On Fri, Oct 22, 2010 at 10:46 AM, Shreyas Bhatewara
> <sbhatewara@vmware.com> wrote:
>>> From: Harvey Harrison [mailto:harvey.harrison@gmail.com]
>>> One question I had when looking into this, why are you doing
>>> byteswapping in the VMXNET_{READ,WRITE}_BAR{0,1}
>>> macros?
>>
>> Because values need to be written in LE orders in registers. For eg. when rx_ring.next2fill index is written to RXPROD reg, it should be converted from CPU order to LE.
>
> Yes, but (unless I'm mistaken) writel always writes out in
> little-endian, so there isn't a need to swap the arguments,
> similarly for readl in the other direction.
That's right, readl() and writel() translate to little-endian.
next prev parent reply other threads:[~2010-10-24 22:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 4:05 [PATCH 1/3] vmxnet3: remove set_flag_le{16,64} helpers Harvey Harrison
2010-10-22 4:05 ` [PATCH 2/3] vmxnet3: annotate hwaddr members as __iomem pointers Harvey Harrison
2010-10-22 17:30 ` Shreyas Bhatewara
2010-10-24 22:43 ` David Miller
2010-10-22 4:05 ` [PATCH 3/3] vmxnet3: fix typo setting confPA Harvey Harrison
2010-10-22 17:31 ` Shreyas Bhatewara
2010-10-22 17:39 ` Harvey Harrison
2010-10-22 17:46 ` Shreyas Bhatewara
2010-10-22 17:52 ` Harvey Harrison
2010-10-22 18:10 ` Shreyas Bhatewara
2010-10-24 22:44 ` David Miller [this message]
2010-10-25 1:46 ` Harvey Harrison
2010-10-24 22:43 ` David Miller
2010-10-22 17:29 ` [PATCH 1/3] vmxnet3: remove set_flag_le{16,64} helpers Shreyas Bhatewara
2010-10-24 22:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101024.154417.116368884.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sbhatewara@vmware.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).