From: David Miller <davem@davemloft.net>
To: cooldavid@cooldavid.org
Cc: netdev@vger.kernel.org, Taoga@yandex.ru, arieslee@jmicron.com,
devinchiu@jmicron.com, hcchao@jmicron.com,
ethanhsiao@jmicron.com
Subject: Re: [PATCH net-next-2.6] jme: Support WoL after shutdown
Date: Sun, 24 Oct 2010 15:51:35 -0700 (PDT) [thread overview]
Message-ID: <20101024.155135.200373852.davem@davemloft.net> (raw)
In-Reply-To: <20101024.154227.232753445.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Sun, 24 Oct 2010 15:42:27 -0700 (PDT)
> From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
> Date: Fri, 22 Oct 2010 09:33:40 +0800
>
>> From: Guo-Fu Tseng <cooldavid@cooldavid.org>
>>
>> Adding shutdown function that setup wake if wol is enabled.
>> Add jme_phy_on in jme_set_100m_half in case it is shutting down
>> or suspending when interface is down(phy_off by default).
>>
>> Reported_and_helped_by: Сtac <Taoga@yandex.ru>
>> Signed-off-by: Guo-Fu Tseng <cooldavid@cooldavid.org>
>
> Applied.
Actually, I had to undo this patch. It generates build
failures:
drivers/net/jme.c: In function 'jme_powersave_phy':
drivers/net/jme.c:1672:3: error: implicit declaration of function 'jme_set_100m_half'
drivers/net/jme.c:1675:4: error: implicit declaration of function 'jme_wait_link'
I guess I'm one of the few people who build with CONFIG_PM
disabled :-)
Please fix this up and resubmit your patch.
prev parent reply other threads:[~2010-10-24 22:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 1:33 [PATCH net-next-2.6] jme: Support WoL after shutdown Guo-Fu Tseng
2010-10-24 22:42 ` David Miller
2010-10-24 22:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101024.155135.200373852.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Taoga@yandex.ru \
--cc=arieslee@jmicron.com \
--cc=cooldavid@cooldavid.org \
--cc=devinchiu@jmicron.com \
--cc=ethanhsiao@jmicron.com \
--cc=hcchao@jmicron.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).