* [PATCH] cxgb3: slay double assignment
@ 2010-10-22 18:00 Kyle McMartin
2010-10-24 23:26 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Kyle McMartin @ 2010-10-22 18:00 UTC (permalink / raw)
To: divy; +Cc: netdev
Noticed this while building Fedora today... It's been
there since around 2007, so I guess a new gcc must be catching
these.
Signed-off-by: Kyle McMartin <kyle@redhat.com>
---
diff --git a/drivers/net/cxgb3/t3_hw.c b/drivers/net/cxgb3/t3_hw.c
index 427c451..997b14b 100644
--- a/drivers/net/cxgb3/t3_hw.c
+++ b/drivers/net/cxgb3/t3_hw.c
@@ -3682,7 +3682,7 @@ static void mc7_prep(struct adapter *adapter, struct mc7 *mc7,
mc7->name = name;
mc7->offset = base_addr - MC7_PMRX_BASE_ADDR;
cfg = t3_read_reg(adapter, mc7->offset + A_MC7_CFG);
- mc7->size = mc7->size = G_DEN(cfg) == M_DEN ? 0 : mc7_calc_size(cfg);
+ mc7->size = G_DEN(cfg) == M_DEN ? 0 : mc7_calc_size(cfg);
mc7->width = G_WIDTH(cfg);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cxgb3: slay double assignment
2010-10-22 18:00 [PATCH] cxgb3: slay double assignment Kyle McMartin
@ 2010-10-24 23:26 ` David Miller
2010-10-24 23:40 ` Kyle McMartin
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2010-10-24 23:26 UTC (permalink / raw)
To: kyle; +Cc: divy, netdev
From: Kyle McMartin <kyle@mcmartin.ca>
Date: Fri, 22 Oct 2010 14:00:03 -0400
> Noticed this while building Fedora today... It's been
> there since around 2007, so I guess a new gcc must be catching
> these.
>
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
This patch doesn't apply.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cxgb3: slay double assignment
2010-10-24 23:26 ` David Miller
@ 2010-10-24 23:40 ` Kyle McMartin
0 siblings, 0 replies; 3+ messages in thread
From: Kyle McMartin @ 2010-10-24 23:40 UTC (permalink / raw)
To: David Miller; +Cc: kyle, divy, netdev
On Sun, Oct 24, 2010 at 04:26:11PM -0700, David Miller wrote:
> > Noticed this while building Fedora today... It's been
> > there since around 2007, so I guess a new gcc must be catching
> > these.
> >
> > Signed-off-by: Kyle McMartin <kyle@redhat.com>
>
> This patch doesn't apply.
>
You already merged a patch to fix it, sorry for the noise.
--Kyle
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-24 23:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-22 18:00 [PATCH] cxgb3: slay double assignment Kyle McMartin
2010-10-24 23:26 ` David Miller
2010-10-24 23:40 ` Kyle McMartin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).