From: David Miller <davem@davemloft.net>
To: therbert@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH 1/2 v3] xps: Improvements in TX queue selection
Date: Mon, 25 Oct 2010 11:56:13 -0700 (PDT) [thread overview]
Message-ID: <20101025.115613.71111117.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTi=Pzxnf=bJXANwz8Rmd8GOUu9oxpO_YF6udJE01@mail.gmail.com>
From: Tom Herbert <therbert@google.com>
Date: Mon, 25 Oct 2010 10:02:05 -0700
> Would this be sufficient:
>
> @@ -825,7 +825,8 @@ static int tcp_transmit_skb(struct sock *sk,
> struct sk_buff *skb
> if (tcp_packets_in_flight(tp) == 0) {
> tcp_ca_event(sk, CA_EVENT_TX_START);
> skb->ooo_okay = 1;
> - }
> + } else
> + skb->ooo_okay = 0;
Or, alternatively, you could clear it at the point it's tested in
the device transmit path.
This might make the changes for SCTP and other protocols much
easier.
For now, either way is fine with me.
next prev parent reply other threads:[~2010-10-25 18:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 20:17 [PATCH 1/2 v3] xps: Improvements in TX queue selection Tom Herbert
2010-10-24 22:32 ` David Miller
2010-10-25 17:02 ` Tom Herbert
2010-10-25 18:56 ` David Miller [this message]
2010-10-26 6:18 ` Helmut Schaa
2010-10-26 15:32 ` Tom Herbert
2010-10-26 15:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101025.115613.71111117.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).