From: David Miller <davem@davemloft.net>
To: therbert@google.com
Cc: helmut.schaa@googlemail.com, netdev@vger.kernel.org,
eric.dumazet@gmail.com
Subject: Re: [PATCH 1/2 v3] xps: Improvements in TX queue selection
Date: Tue, 26 Oct 2010 08:35:37 -0700 (PDT) [thread overview]
Message-ID: <20101026.083537.226783463.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTimMrqhWbnLXk1xbYPY7WT7Gazn5G=S1QvVkZ86Y@mail.gmail.com>
From: Tom Herbert <therbert@google.com>
Date: Tue, 26 Oct 2010 08:32:59 -0700
>> Wouldn't that break mac80211 QoS again for bridged AP mode interfaces (see
>> commit deabc772f39405054a438d711f408d2d94d26d96, "net: fix tx queue selection
>> for bridged devices implementing select_queue")?
>>
> Yes, looks like that would break. I'll fix that.
>
> If a device only has one real TX queue should we still call
> ndo_select_queue, or can we bypass it? (to save one conditional)
Probably bypass, for now.
prev parent reply other threads:[~2010-10-26 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 20:17 [PATCH 1/2 v3] xps: Improvements in TX queue selection Tom Herbert
2010-10-24 22:32 ` David Miller
2010-10-25 17:02 ` Tom Herbert
2010-10-25 18:56 ` David Miller
2010-10-26 6:18 ` Helmut Schaa
2010-10-26 15:32 ` Tom Herbert
2010-10-26 15:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101026.083537.226783463.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=helmut.schaa@googlemail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).