* [PATCH] drivers/net: sgiseeq: fix return on error
@ 2010-10-26 16:45 Nicolas Kaiser
2010-10-26 17:02 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Kaiser @ 2010-10-26 16:45 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, linux-kernel
If we continue on error, we'd likely free the IRQ that we
didn't get, right?
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
drivers/net/sgiseeq.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/sgiseeq.c b/drivers/net/sgiseeq.c
index 9265315..3a0cc63 100644
--- a/drivers/net/sgiseeq.c
+++ b/drivers/net/sgiseeq.c
@@ -531,7 +531,7 @@ static int sgiseeq_open(struct net_device *dev)
if (request_irq(irq, sgiseeq_interrupt, 0, sgiseeqstr, dev)) {
printk(KERN_ERR "Seeq8003: Can't get irq %d\n", dev->irq);
- err = -EAGAIN;
+ return -EAGAIN;
}
err = init_seeq(dev, sp, sregs);
--
1.7.2.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/net: sgiseeq: fix return on error
2010-10-26 16:45 [PATCH] drivers/net: sgiseeq: fix return on error Nicolas Kaiser
@ 2010-10-26 17:02 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-10-26 17:02 UTC (permalink / raw)
To: nikai; +Cc: netdev, linux-kernel
From: Nicolas Kaiser <nikai@nikai.net>
Date: Tue, 26 Oct 2010 18:45:05 +0200
> If we continue on error, we'd likely free the IRQ that we
> didn't get, right?
>
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
Yep, applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-26 17:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-26 16:45 [PATCH] drivers/net: sgiseeq: fix return on error Nicolas Kaiser
2010-10-26 17:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).