From: David Miller <davem@davemloft.net>
To: fleitner@redhat.com
Cc: netdev@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [PATCH] net: reset gso header when the copied skb is linearized
Date: Tue, 26 Oct 2010 11:31:57 -0700 (PDT) [thread overview]
Message-ID: <20101026.113157.233700961.davem@davemloft.net> (raw)
In-Reply-To: <1288045398-3110-1-git-send-email-fleitner@redhat.com>
From: Flavio Leitner <fleitner@redhat.com>
Date: Mon, 25 Oct 2010 20:23:18 -0200
> The gso header is incorrect when the copied skb is
> linearized. This patch creates another helper function
> to copy the gso header when it is appropriated
>
> Signed-off-by: Flavio Leitner <fleitner@redhat.com>
I don't understand why the GSO information should be
omitted just because we are creating a linearlized
version of the SKB?
The packet still could have a larger than MSS size,
and thus be composed of multiple actual segments for
the network.
next prev parent reply other threads:[~2010-10-26 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 22:23 [PATCH] net: reset gso header when the copied skb is linearized Flavio Leitner
2010-10-26 18:31 ` David Miller [this message]
2010-10-26 19:25 ` Flavio Leitner
2010-10-26 19:28 ` David Miller
2010-10-26 19:38 ` Herbert Xu
2010-11-04 20:35 ` Flavio Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101026.113157.233700961.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fleitner@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).