From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: sysoleg@yandex.ru, netdev@vger.kernel.org, aspam@cox.net
Subject: Re: kernel panic in fib_rules_lookup [2.6.27.7 vendor-patched]
Date: Tue, 26 Oct 2010 11:43:21 -0700 (PDT) [thread overview]
Message-ID: <20101026.114321.27791534.davem@davemloft.net> (raw)
In-Reply-To: <1287863065.2658.533.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 23 Oct 2010 21:44:25 +0200
> [PATCH] fib: fix fib_nl_newrule()
>
> Some panic reports in fib_rules_lookup() show a rule could have a NULL
> pointer as a next pointer in the rules_list.
>
> This can actually happen because of a bug in fib_nl_newrule() : It
> checks if current rule is the destination of unresolved gotos. (Other
> rules have gotos to this about to be inserted rule)
>
> Problem is it does the resolution of the gotos before the rule is
> inserted in the rules_list (and has a valid next pointer)
>
> Fix this by moving the rules_list insertion before the changes on gotos.
>
> A lockless reader can not any more follow a ctarget pointer, unless
> destination is ready (has a valid next pointer)
>
> Reported-by: Oleg A. Arkhangelsky <sysoleg@yandex.ru>
> Reported-by: Joe Buehler <aspam@cox.net>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks Eric.
next prev parent reply other threads:[~2010-10-26 18:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 17:14 kernel panic in fib_rules_lookup [2.6.27.7 vendor-patched] Joe Buehler
2010-10-12 17:40 ` Eric Dumazet
2010-10-13 11:18 ` Joe Buehler
2010-10-20 17:43 ` Joe Buehler
2010-10-20 22:05 ` Eric Dumazet
2010-10-22 20:30 ` Joe Buehler
2010-10-23 3:44 ` Eric Dumazet
2010-10-23 15:11 ` Eric Dumazet
2010-10-23 15:24 ` Eric Dumazet
2010-10-23 15:40 ` Joe Buehler
2010-10-23 16:07 ` Eric Dumazet
2010-10-23 15:33 ` Joe Buehler
2010-10-23 16:35 ` Eric Dumazet
2010-10-23 17:37 ` "Oleg A. Arkhangelsky"
2010-10-23 19:44 ` Eric Dumazet
2010-10-26 18:43 ` David Miller [this message]
2010-10-26 13:29 ` Joe Buehler
2010-10-26 13:36 ` Eric Dumazet
2010-10-26 13:53 ` Joe Buehler
2010-10-26 13:58 ` Eric Dumazet
2010-10-26 14:33 ` Eric Dumazet
2010-10-26 14:41 ` Joe Buehler
2010-10-27 21:01 ` Joe Buehler
2010-10-27 21:05 ` Eric Dumazet
2010-12-02 13:36 ` Joe Buehler
2010-12-02 14:04 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101026.114321.27791534.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aspam@cox.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sysoleg@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).