From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: ursula.braun@de.ibm.com, netdev@vger.kernel.org,
linux-s390@vger.kernel.org, vosburgh@de.ibm.com
Subject: Re: [patch 1/1] [PATCH BUG_FIX] ipv6: fix refcnt problem related to POSTDAD state
Date: Wed, 27 Oct 2010 11:10:14 -0700 (PDT) [thread overview]
Message-ID: <20101027.111014.260072078.davem@davemloft.net> (raw)
In-Reply-To: <20101025230132.GA5474@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 25 Oct 2010 16:01:32 -0700
> On Mon, Oct 25, 2010 at 11:06:43AM +0200, Ursula Braun wrote:
>> Subject: [patch 1/1] [PATCH BUG_FIX] ipv6: fix refcnt problem related to POSTDAD state
>>
>> From: Ursula Braun <ursula.braun@de.ibm.com>
>>
>> After running this bonding setup script
>> modprobe bonding miimon=100 mode=0 max_bonds=1
>> ifconfig bond0 10.1.1.1/16
>> ifenslave bond0 eth1
>> ifenslave bond0 eth3
>> on s390 with qeth-driven slaves, modprobe -r fails with this message
>> unregister_netdevice: waiting for bond0 to become free. Usage count = 1
>> due to twice detection of duplicate address.
>> Problem is caused by a missing decrease of ifp->refcnt in addrconf_dad_failure.
>> An extra call of in6_ifa_put(ifp) solves it.
>> Problem has been introduced with commit f2344a131bccdbfc5338e17fa71a807dee7944fa.
>>
>> Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
>> Cc: David S. Miller <davem@davemloft.net>
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> Thanks for catching this!
Applied, thanks everyone.
prev parent reply other threads:[~2010-10-27 18:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 9:06 [patch 0/1] ipv6 POSTDAD fix Ursula Braun
2010-10-25 9:06 ` [patch 1/1] [PATCH BUG_FIX] ipv6: fix refcnt problem related to POSTDAD state Ursula Braun
2010-10-25 23:01 ` Herbert Xu
2010-10-27 18:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101027.111014.260072078.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ursula.braun@de.ibm.com \
--cc=vosburgh@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).