From: David Miller <davem@davemloft.net>
To: nelhage@ksplice.com
Cc: robert.olsson@its.uu.se, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, eugene@redhat.com
Subject: Re: [PATCH] pktgen: Remove a dangerous debug print.
Date: Wed, 27 Oct 2010 12:30:43 -0700 (PDT) [thread overview]
Message-ID: <20101027.123043.241428851.davem@davemloft.net> (raw)
In-Reply-To: <20101027192808.GP16803@ksplice.com>
From: Nelson Elhage <nelhage@ksplice.com>
Date: Wed, 27 Oct 2010 15:28:08 -0400
> How would you feel about limiting the debug print to at most, say, 512 or 1024
> bytes? Even if it's only accessible to root by default, I don't a userspace
> program should be able to accidentally corrupt the kernel stack by writing too
> many bytes to a file in /proc.
Why not? He can just as easily "cat whatever >/dev/kmem" or similar?
And I'm sure there are other proc files that can cause similar damage
such as the PCI device control files.
next prev parent reply other threads:[~2010-10-27 19:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 19:13 [PATCH] pktgen: Remove a dangerous debug print Nelson Elhage
2010-10-27 19:21 ` David Miller
2010-10-27 19:28 ` Nelson Elhage
2010-10-27 19:30 ` David Miller [this message]
2010-10-27 19:41 ` Eric Dumazet
2010-10-27 19:49 ` Nelson Elhage
2010-10-27 20:38 ` Ben Greear
2010-10-27 22:12 ` [patch] fix stack overflow in pktgen_if_write() Dan Carpenter
2010-10-27 22:40 ` Dan Carpenter
2010-10-27 22:43 ` [patch v2] " Dan Carpenter
2010-10-27 23:06 ` Nelson Elhage
2010-10-28 6:05 ` Dan Carpenter
2010-10-28 6:05 ` [patch v3] " Dan Carpenter
2010-10-28 15:22 ` Nelson Elhage
2010-10-28 16:28 ` Dan Carpenter
2010-10-28 16:30 ` Nelson Elhage
2010-10-28 23:11 ` Andi Kleen
2010-11-01 3:47 ` Dan Carpenter
2010-10-28 15:20 ` [PATCH] pktgen: Limit how much data we copy onto the stack Nelson Elhage
2010-10-28 18:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101027.123043.241428851.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eugene@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nelhage@ksplice.com \
--cc=netdev@vger.kernel.org \
--cc=robert.olsson@its.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).