From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: leitao@linux.vnet.ibm.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2] ehea: Fixing statistics
Date: Wed, 27 Oct 2010 14:21:41 -0700 (PDT) [thread overview]
Message-ID: <20101027.142141.104047821.davem@davemloft.net> (raw)
In-Reply-To: <1288205610.2658.2.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 27 Oct 2010 20:53:30 +0200
> Le mercredi 27 octobre 2010 à 14:45 -0400, Breno Leitao a écrit :
>> (Applied over Eric's "ehea: fix use after free" patch)
>>
>> Currently ehea stats are broken. The bytes counters are got from
>> the hardware, while the packets counters are got from the device
>> driver. Also, the device driver counters are resetted during the
>> the down process, and the hardware aren't, causing some weird
>> numbers.
>>
>> This patch just consolidates the packets and bytes on the device
>> driver.
>>
>> Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
>
> Reviewed-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
prev parent reply other threads:[~2010-10-27 21:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 18:03 [PATCH] ehea: Fixing statistics leitao
2010-10-26 18:48 ` Eric Dumazet
2010-10-27 5:21 ` [PATCH] ehea: fix use after free Eric Dumazet
2010-10-27 16:05 ` Breno Leitao
2010-10-27 18:39 ` David Miller
2010-10-27 18:45 ` [PATCH v2] ehea: Fixing statistics Breno Leitao
2010-10-27 18:53 ` Eric Dumazet
2010-10-27 21:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101027.142141.104047821.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=leitao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).