From: Jarek Poplawski <jarkao2@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Jesse Gross <jesse@nicira.com>
Subject: Re: [BUG net-2.6 vlan/bonding] lockdep splats
Date: Wed, 27 Oct 2010 12:03:34 +0000 [thread overview]
Message-ID: <20101027120334.GA11247@ff.dom.local> (raw)
In-Reply-To: <1288175070.2709.86.camel@edumazet-laptop>
On Wed, Oct 27, 2010 at 12:24:30PM +0200, Eric Dumazet wrote:
> On latest net-2.6 kernel I got following splat, not sure its related to
> vlan changes...
Seems to be even older. Could you try this patch?
Thanks,
Jarek P.
---
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index beb3b7c..bdb68a6 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -493,9 +493,9 @@ static void bond_vlan_rx_register(struct net_device *bond_dev,
struct slave *slave;
int i;
- write_lock(&bond->lock);
+ write_lock_bh(&bond->lock);
bond->vlgrp = grp;
- write_unlock(&bond->lock);
+ write_unlock_bh(&bond->lock);
bond_for_each_slave(bond, slave, i) {
struct net_device *slave_dev = slave->dev;
next prev parent reply other threads:[~2010-10-27 12:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 10:24 [BUG net-2.6 vlan/bonding] lockdep splats Eric Dumazet
2010-10-27 12:03 ` Jarek Poplawski [this message]
2010-10-27 13:00 ` Eric Dumazet
2010-10-27 17:08 ` [PATCH] bonding: Fix lockdep warning after bond_vlan_rx_register() Jarek Poplawski
2010-10-27 21:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101027120334.GA11247@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).