From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, bphilips@novell.com,
bhutchings@solarflare.com, emil.s.tantilov@intel.com
Subject: Re: [net-2.6 PATCH] ixgb: call pci_disable_device in ixgb_remove
Date: Thu, 28 Oct 2010 10:19:57 -0700 (PDT) [thread overview]
Message-ID: <20101028.101957.71111430.davem@davemloft.net> (raw)
In-Reply-To: <20101028105949.27748.82780.stgit@localhost6.localdomain6>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 28 Oct 2010 03:59:49 -0700
> From: Emil Tantilov <emil.s.tantilov@intel.com>
>
> ixgb fails to work after reload on recent kernels:
>
> rmmod ixgb (dev->current_state = PCI_UNKNOWN)
> modprobe ixgb (pci_enable_device will bail leaving current_state to PCI_UNKNOWN)
> ifup eth0
> do_IRQ: 2.82 No irq handler for vector (irq -1)
>
> The issue was exposed by commit fcd097f31a6ee207cc0c3da9cccd2a86d4334785
> PCI: MSI: Remove unsafe and unnecessary hardware access
>
> which avoids HW writes for power states != PCI_D0
>
> CC: Ben Hutchings <bhutchings@solarflare.com>
> Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
> Tested-by: Jeff Pieper <jeffrey.e.pieper@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
prev parent reply other threads:[~2010-10-28 17:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 10:59 [net-2.6 PATCH] ixgb: call pci_disable_device in ixgb_remove Jeff Kirsher
2010-10-28 17:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028.101957.71111430.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=bphilips@novell.com \
--cc=emil.s.tantilov@intel.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).