From: David Miller <davem@davemloft.net>
To: divy@chelsio.com
Cc: nacc@us.ibm.com, eric.dumazet@gmail.com, sonnyrao@us.ibm.com,
dm@chelsio.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cxgb3: fix crash due to manipulating queues before registration
Date: Thu, 28 Oct 2010 10:28:30 -0700 (PDT) [thread overview]
Message-ID: <20101028.102830.115930449.davem@davemloft.net> (raw)
In-Reply-To: <4CC919B1.1040602@chelsio.com>
From: Divy Le Ray <divy@chelsio.com>
Date: Wed, 27 Oct 2010 23:35:29 -0700
> On 10/27/2010 10:06 PM, Nishanth Aravamudan wrote:
>> Hi Eric,
>>
>> Something like the following?:
>>
>> Thanks,
>> Nish
>>
>>
>> Along the same lines as "cxgb4: fix crash due to manipulating queues
>> before registration" (8f6d9f40476895571df039b6f1f5230ec7faebad),
>> before
>> commit "net: allocate tx queues in register_netdevice"
>> netif_tx_stop_all_queues and related functions could be used between
>> device allocation and registration but now only after registration.
>> cxgb4 has such a call before registration and crashes now. Move it
>> after register_netdev.
>>
>> Signed-off-by: Nishanth Aravamudan<nacc@us.ibm.com>
>
> Acked-by: Divy Le Ray <divy@chelsio.com>
Applied.
prev parent reply other threads:[~2010-10-28 17:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 1:54 cxgb3: kernel access of bad area with v2.6.36-6794-g12ba8d1 Nishanth Aravamudan
2010-10-28 3:29 ` Eric Dumazet
2010-10-28 5:06 ` [PATCH] cxgb3: fix crash due to manipulating queues before registration Nishanth Aravamudan
2010-10-28 5:18 ` Eric Dumazet
2010-10-28 5:23 ` Nishanth Aravamudan
2010-10-28 17:28 ` David Miller
2010-10-28 6:35 ` Divy Le Ray
2010-10-28 17:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028.102830.115930449.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=divy@chelsio.com \
--cc=dm@chelsio.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nacc@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=sonnyrao@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).