From: David Miller <davem@davemloft.net>
To: xemul@parallels.com
Cc: p_gortmaker@yahoo.com, netdev@vger.kernel.org
Subject: Re: [PATCH] 8390: Don't oops on starting dev queue
Date: Thu, 28 Oct 2010 10:28:48 -0700 (PDT) [thread overview]
Message-ID: <20101028.102848.48509225.davem@davemloft.net> (raw)
In-Reply-To: <4CC93BCE.4020303@parallels.com>
From: Pavel Emelyanov <xemul@parallels.com>
Date: Thu, 28 Oct 2010 13:01:02 +0400
> The __NS8390_init tries to start the device queue before the
> device is registered. This results in an oops (snipped):
>
> [ 2.865493] BUG: unable to handle kernel NULL pointer dereference at 0000000000000010
> [ 2.866106] IP: [<ffffffffa000602a>] netif_start_queue+0xb/0x12 [8390]
> [ 2.881267] Call Trace:
> [ 2.881437] [<ffffffffa000624d>] __NS8390_init+0x102/0x15a [8390]
> [ 2.881999] [<ffffffffa00062ae>] NS8390_init+0x9/0xb [8390]
> [ 2.882237] [<ffffffffa000d820>] ne2k_pci_init_one+0x297/0x354 [ne2k_pci]
> [ 2.882955] [<ffffffff811c7a0e>] local_pci_probe+0x12/0x16
> [ 2.883308] [<ffffffff811c85ad>] pci_device_probe+0xc3/0xef
> [ 2.884049] [<ffffffff8129218d>] driver_probe_device+0xbe/0x14b
> [ 2.884937] [<ffffffff81292260>] __driver_attach+0x46/0x62
> [ 2.885170] [<ffffffff81291788>] bus_for_each_dev+0x49/0x78
> [ 2.885781] [<ffffffff81291fbb>] driver_attach+0x1c/0x1e
> [ 2.886089] [<ffffffff812912ab>] bus_add_driver+0xba/0x227
> [ 2.886330] [<ffffffff8129259a>] driver_register+0x9e/0x115
> [ 2.886933] [<ffffffff811c8815>] __pci_register_driver+0x50/0xac
> [ 2.887785] [<ffffffffa001102c>] ne2k_pci_init+0x2c/0x2e [ne2k_pci]
> [ 2.888093] [<ffffffff81000212>] do_one_initcall+0x7c/0x130
> [ 2.888693] [<ffffffff8106d74f>] sys_init_module+0x99/0x1da
> [ 2.888946] [<ffffffff81002a2b>] system_call_fastpath+0x16/0x1b
>
> This happens because the netif_start_queue sets respective bit on the dev->_tx
> array which is not yet allocated.
>
> As far as I understand the code removing the netif_start_queue from __NS8390_init
> is OK, since queue will be started later on device open. Plz, correct me if I'm wrong.
>
> Found in the Dave's current tree, so he's in Cc.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
prev parent reply other threads:[~2010-10-28 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 9:01 [PATCH] 8390: Don't oops on starting dev queue Pavel Emelyanov
2010-10-28 12:22 ` Pavel Emelyanov
2010-10-28 17:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028.102848.48509225.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).