From: David Miller <davem@davemloft.net>
To: torvalds@linux-foundation.org
Cc: netdev@vger.kernel.org, drosenberg@vsecurity.com,
jon.maloy@ericsson.com, allan.stephens@windriver.com
Subject: Re: [PATCH] net: Limit socket I/O iovec total length to INT_MAX.
Date: Thu, 28 Oct 2010 11:37:46 -0700 (PDT) [thread overview]
Message-ID: <20101028.113746.104048682.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTinq5iYU3A41vLHLLWVpoS-A4mB-RYrrWYCGKk+-@mail.gmail.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Thu, 28 Oct 2010 11:33:56 -0700
> On Thu, Oct 28, 2010 at 11:22 AM, David Miller <davem@davemloft.net> wrote:
>>
>> - int tot_len = 0;
>> + size_t tot_len = 0;
>
> I would actually keep "tot_len" as an "int".
...
>> +int verify_iovec(struct msghdr *m, struct iovec *iov, struct sockaddr *address, int mode)
>> {
>> int size, ct;
>> - long err;
>> + size_t err;
>
> Same thing here. Making "err" be an "int" is actually the right thing
> to do, because then it matches the return type (iow, if it was any
> other type, there would be an implicit cast, and if it didn't fit in
> "int", that would be a bug anyway).
Yep, agreed on all counts, I'll make those changes.
next prev parent reply other threads:[~2010-10-28 18:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 18:22 [PATCH] net: Limit socket I/O iovec total length to INT_MAX David Miller
2010-10-28 18:33 ` Linus Torvalds
2010-10-28 18:37 ` David Miller [this message]
2010-10-29 6:40 ` Linus Torvalds
2010-10-29 14:00 ` Dan Rosenberg
2010-10-29 15:28 ` Linus Torvalds
2010-10-29 16:21 ` Linus Torvalds
2010-10-29 16:45 ` Al Viro
2010-10-29 17:01 ` Linus Torvalds
2010-10-29 17:32 ` Al Viro
2010-10-29 19:32 ` David Miller
2010-10-29 19:37 ` Linus Torvalds
2010-10-29 19:55 ` David Miller
2010-10-29 20:22 ` Dan Rosenberg
2010-10-29 18:51 ` Rick Jones
2010-10-29 18:59 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028.113746.104048682.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=allan.stephens@windriver.com \
--cc=drosenberg@vsecurity.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).