From: David Miller <davem@davemloft.net>
To: andy.grover@oracle.com
Cc: torvalds@linux-foundation.org, jon.maloy@ericsson.com,
netdev@vger.kernel.org, drosenberg@vsecurity.com,
security@kernel.org, allan.stephens@windriver.com,
rds-devel@oss.oracle.com
Subject: Re: [Security] TIPC security issues
Date: Thu, 28 Oct 2010 11:49:41 -0700 (PDT) [thread overview]
Message-ID: <20101028.114941.39177249.davem@davemloft.net> (raw)
In-Reply-To: <4CC9C4B0.50404@oracle.com>
From: Andy Grover <andy.grover@oracle.com>
Date: Thu, 28 Oct 2010 11:45:04 -0700
> Yes that's right, it's to map a memory region that will be the target
> of an RDMA operation. I don't know why struct rds_iovec was used
> instead of struct iovec, but I think we're stuck, since it's part of
> our socket API.
>
> I'll send DaveM patches to fix those two immediately-identified
> problems today, and we'll take a good long look at the rest of the
> code for further issues.
FWIW, I would strongly suggest that you copy the iovecs into the
kernel before parsing them like sys_sendmsg() and sys_recvmsg() do in
net/socket.c as part of these fixes.
next prev parent reply other threads:[~2010-10-28 18:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 23:45 TIPC security issues Dan Rosenberg
2010-10-22 0:31 ` [Security] " Linus Torvalds
2010-10-25 2:14 ` David Miller
2010-10-25 3:42 ` Linus Torvalds
2010-10-25 5:28 ` David Miller
2010-10-27 17:29 ` David Miller
2010-10-27 17:37 ` Linus Torvalds
2010-10-27 17:50 ` David Miller
2010-10-27 18:26 ` Dan Rosenberg
2010-10-27 18:34 ` David Miller
2010-10-27 18:51 ` Linus Torvalds
2010-10-27 19:27 ` David Miller
2010-10-28 15:32 ` Linus Torvalds
2010-10-28 18:45 ` Andy Grover
2010-10-28 18:49 ` David Miller [this message]
2010-10-27 18:27 ` Paul Gortmaker
2010-10-27 18:35 ` David Miller
2010-10-27 19:00 ` Paul Gortmaker
2010-10-28 19:51 ` Paul Gortmaker
2010-10-22 13:49 ` Jon Maloy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028.114941.39177249.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=allan.stephens@windriver.com \
--cc=andy.grover@oracle.com \
--cc=drosenberg@vsecurity.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=security@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).