From: David Miller <davem@davemloft.net>
To: leedom@chelsio.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] cxgb4vf: fix crash due to manipulating queues before registration
Date: Thu, 28 Oct 2010 13:21:22 -0700 (PDT) [thread overview]
Message-ID: <20101028.132122.245402585.davem@davemloft.net> (raw)
In-Reply-To: <1288297007-663-1-git-send-email-leedom@chelsio.com>
From: Casey Leedom <leedom@chelsio.com>
Date: Thu, 28 Oct 2010 13:16:47 -0700
> Before commit "net: allocate tx queues in register_netdevice"
> netif_tx_stop_all_queues and related functions could be used between
> device allocation and registration but now only after registration.
> cxgb4 has such a call before registration and crashes now. Move it
> after register_netdev.
>
> Signed-off-by: Casey Leedom <leedom@chelsio.com>
Why are you manipulating the queue at all here?
The queue state is "don't care" at this point in time,
and has no meaning until ->open() is invoked.
next prev parent reply other threads:[~2010-10-28 20:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 20:16 [PATCH] cxgb4vf: fix crash due to manipulating queues before registration Casey Leedom
2010-10-28 20:21 ` David Miller [this message]
2010-10-28 21:16 ` Casey Leedom
2010-10-29 7:36 ` Dimitrios Michailidis
2010-10-29 20:05 ` David Miller
2010-11-01 21:02 ` Divy Le Ray
2010-11-01 21:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028.132122.245402585.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).