From: Jeff Garzik <jgarzik@redhat.com>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Wyborny, Carolyn" <carolyn.wyborny@intel.com>
Subject: Re: ethtool: missing implementation of n_priv_flags
Date: Thu, 28 Oct 2010 17:53:59 -0400 [thread overview]
Message-ID: <20101028215358.GB9421@shell.devel.redhat.com> (raw)
In-Reply-To: <F169D4F5E1F1974DBFAFABF47F60C10AA5E60671@orsmsx507.amr.corp.intel.com>
On Thu, Oct 28, 2010 at 01:34:34PM -0700, Brandeburg, Jesse wrote:
> Was just looking at implementing the driver private flags to add a new feature to
> a driver.
>
> It appears that nothing in the core ethtool.c ever accesses or prints n_priv_flags,
> even if a driver assigns it (which none in the kernel currently do)
>
> Is this just an oversight?
It was waiting for the first user, basically... I created an example
kernel patch for one Intel driver, but you guys didn't seem interested
in it at the time. Glad to see it's getting some attention.
Jeff
prev parent reply other threads:[~2010-10-28 21:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 20:34 ethtool: missing implementation of n_priv_flags Brandeburg, Jesse
2010-10-28 21:00 ` Ben Hutchings
2010-10-28 21:10 ` Brandeburg, Jesse
2010-10-28 21:54 ` Ben Hutchings
2010-10-28 21:59 ` Jeff Garzik
2010-10-28 21:53 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028215358.GB9421@shell.devel.redhat.com \
--to=jgarzik@redhat.com \
--cc=carolyn.wyborny@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).