* ethtool: missing implementation of n_priv_flags
@ 2010-10-28 20:34 Brandeburg, Jesse
2010-10-28 21:00 ` Ben Hutchings
2010-10-28 21:53 ` Jeff Garzik
0 siblings, 2 replies; 6+ messages in thread
From: Brandeburg, Jesse @ 2010-10-28 20:34 UTC (permalink / raw)
To: jgarzik@redhat.com
Cc: netdev@vger.kernel.org, Wyborny, Carolyn, Brandeburg, Jesse
Was just looking at implementing the driver private flags to add a new feature to
a driver.
It appears that nothing in the core ethtool.c ever accesses or prints n_priv_flags,
even if a driver assigns it (which none in the kernel currently do)
Is this just an oversight?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ethtool: missing implementation of n_priv_flags
2010-10-28 20:34 ethtool: missing implementation of n_priv_flags Brandeburg, Jesse
@ 2010-10-28 21:00 ` Ben Hutchings
2010-10-28 21:10 ` Brandeburg, Jesse
2010-10-28 21:53 ` Jeff Garzik
1 sibling, 1 reply; 6+ messages in thread
From: Ben Hutchings @ 2010-10-28 21:00 UTC (permalink / raw)
To: Brandeburg, Jesse
Cc: jgarzik@redhat.com, netdev@vger.kernel.org, Wyborny, Carolyn
Brandeburg, Jesse wrote:
> Was just looking at implementing the driver private flags to add a new feature to
> a driver.
>
> It appears that nothing in the core ethtool.c ever accesses or prints n_priv_flags,
> even if a driver assigns it (which none in the kernel currently do)
[...]
You mean net/core/ethtool.c? Or the ethtool utility?
If you set it in your get_drvinfo() operation then it will be copied out.
As for the ethtool utility, I've implemented some generic flag parsing and
printing functionality so it shouldn't be too hard to use that for private
flags.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ethtool: missing implementation of n_priv_flags
2010-10-28 21:00 ` Ben Hutchings
@ 2010-10-28 21:10 ` Brandeburg, Jesse
2010-10-28 21:54 ` Ben Hutchings
0 siblings, 1 reply; 6+ messages in thread
From: Brandeburg, Jesse @ 2010-10-28 21:10 UTC (permalink / raw)
To: Ben Hutchings
Cc: jgarzik@redhat.com, netdev@vger.kernel.org, Wyborny, Carolyn
On Thu, 28 Oct 2010, Ben Hutchings wrote:
> Brandeburg, Jesse wrote:
> > Was just looking at implementing the driver private flags to add a new feature to
> > a driver.
> >
> > It appears that nothing in the core ethtool.c ever accesses or prints n_priv_flags,
> > even if a driver assigns it (which none in the kernel currently do)
> [...]
>
> You mean net/core/ethtool.c? Or the ethtool utility?
The ethtool utility (the app that would print the 1-1 match between bits
and strings)
> If you set it in your get_drvinfo() operation then it will be copied out.
> As for the ethtool utility, I've implemented some generic flag parsing and
> printing functionality so it shouldn't be too hard to use that for private
> flags.
Right, I see the code where it gets copied into drvinfo in the kernel but
nothing ever prints it on the userspace side.
We'll take a shot at an implementation in the ethtool proper and post it
(hopefully soon). I imagine it will just be printed when one runs the
command
# ethtool ethX
and the set side will probably be implemented as part of -s
# ethtool -s ethX pflag [0-0xFFFFFFFF]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ethtool: missing implementation of n_priv_flags
2010-10-28 21:10 ` Brandeburg, Jesse
@ 2010-10-28 21:54 ` Ben Hutchings
2010-10-28 21:59 ` Jeff Garzik
0 siblings, 1 reply; 6+ messages in thread
From: Ben Hutchings @ 2010-10-28 21:54 UTC (permalink / raw)
To: Brandeburg, Jesse
Cc: jgarzik@redhat.com, netdev@vger.kernel.org, Wyborny, Carolyn
Brandeburg, Jesse wrote:
[...]
> We'll take a shot at an implementation in the ethtool proper and post it
> (hopefully soon). I imagine it will just be printed when one runs the
> command
> # ethtool ethX
>
> and the set side will probably be implemented as part of -s
>
> # ethtool -s ethX pflag [0-0xFFFFFFFF]
This is crap. Use ETHTOOL_GSTRINGS with string_set = ETH_SS_PRIV_FLAGS
to get the flag names, then convert that array into an array of struct
cmdline_info and parse the flags by name.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ethtool: missing implementation of n_priv_flags
2010-10-28 21:54 ` Ben Hutchings
@ 2010-10-28 21:59 ` Jeff Garzik
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2010-10-28 21:59 UTC (permalink / raw)
To: Ben Hutchings; +Cc: Brandeburg, Jesse, netdev@vger.kernel.org, Wyborny, Carolyn
On Thu, Oct 28, 2010 at 10:54:18PM +0100, Ben Hutchings wrote:
> Brandeburg, Jesse wrote:
> [...]
> > We'll take a shot at an implementation in the ethtool proper and post it
> > (hopefully soon). I imagine it will just be printed when one runs the
> > command
> > # ethtool ethX
> >
> > and the set side will probably be implemented as part of -s
> >
> > # ethtool -s ethX pflag [0-0xFFFFFFFF]
>
> This is crap. Use ETHTOOL_GSTRINGS with string_set = ETH_SS_PRIV_FLAGS
> to get the flag names, then convert that array into an array of struct
> cmdline_info and parse the flags by name.
Indeed. It was intended to be a flexible interface where a driver can
easily pass arbitrary text-named flags to the user for setting/clearing.
If e1000e has a special Intel-specific feature that makes the NIC
process packets more rapidly, you could select the string "go_faster" in
the ethtool private flags interface. The ethtool utility reads the
strings, which determine the flags exported for that network interface.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ethtool: missing implementation of n_priv_flags
2010-10-28 20:34 ethtool: missing implementation of n_priv_flags Brandeburg, Jesse
2010-10-28 21:00 ` Ben Hutchings
@ 2010-10-28 21:53 ` Jeff Garzik
1 sibling, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2010-10-28 21:53 UTC (permalink / raw)
To: Brandeburg, Jesse; +Cc: netdev@vger.kernel.org, Wyborny, Carolyn
On Thu, Oct 28, 2010 at 01:34:34PM -0700, Brandeburg, Jesse wrote:
> Was just looking at implementing the driver private flags to add a new feature to
> a driver.
>
> It appears that nothing in the core ethtool.c ever accesses or prints n_priv_flags,
> even if a driver assigns it (which none in the kernel currently do)
>
> Is this just an oversight?
It was waiting for the first user, basically... I created an example
kernel patch for one Intel driver, but you guys didn't seem interested
in it at the time. Glad to see it's getting some attention.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-10-28 21:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-28 20:34 ethtool: missing implementation of n_priv_flags Brandeburg, Jesse
2010-10-28 21:00 ` Ben Hutchings
2010-10-28 21:10 ` Brandeburg, Jesse
2010-10-28 21:54 ` Ben Hutchings
2010-10-28 21:59 ` Jeff Garzik
2010-10-28 21:53 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).