From: Jeff Garzik <jgarzik@redhat.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Wyborny, Carolyn" <carolyn.wyborny@intel.com>
Subject: Re: ethtool: missing implementation of n_priv_flags
Date: Thu, 28 Oct 2010 17:59:21 -0400 [thread overview]
Message-ID: <20101028215921.GC9421@shell.devel.redhat.com> (raw)
In-Reply-To: <20101028215417.GL15074@solarflare.com>
On Thu, Oct 28, 2010 at 10:54:18PM +0100, Ben Hutchings wrote:
> Brandeburg, Jesse wrote:
> [...]
> > We'll take a shot at an implementation in the ethtool proper and post it
> > (hopefully soon). I imagine it will just be printed when one runs the
> > command
> > # ethtool ethX
> >
> > and the set side will probably be implemented as part of -s
> >
> > # ethtool -s ethX pflag [0-0xFFFFFFFF]
>
> This is crap. Use ETHTOOL_GSTRINGS with string_set = ETH_SS_PRIV_FLAGS
> to get the flag names, then convert that array into an array of struct
> cmdline_info and parse the flags by name.
Indeed. It was intended to be a flexible interface where a driver can
easily pass arbitrary text-named flags to the user for setting/clearing.
If e1000e has a special Intel-specific feature that makes the NIC
process packets more rapidly, you could select the string "go_faster" in
the ethtool private flags interface. The ethtool utility reads the
strings, which determine the flags exported for that network interface.
Jeff
next prev parent reply other threads:[~2010-10-28 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 20:34 ethtool: missing implementation of n_priv_flags Brandeburg, Jesse
2010-10-28 21:00 ` Ben Hutchings
2010-10-28 21:10 ` Brandeburg, Jesse
2010-10-28 21:54 ` Ben Hutchings
2010-10-28 21:59 ` Jeff Garzik [this message]
2010-10-28 21:53 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028215921.GC9421@shell.devel.redhat.com \
--to=jgarzik@redhat.com \
--cc=bhutchings@solarflare.com \
--cc=carolyn.wyborny@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).