From: David Miller <davem@davemloft.net>
To: segooon@gmail.com
Cc: kernel-janitors@vger.kernel.org, ebiederm@xmission.com,
eric.dumazet@gmail.com, tj@kernel.org, serge@hallyn.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: core: scm: fix information leak to userland
Date: Sat, 30 Oct 2010 12:12:38 -0700 (PDT) [thread overview]
Message-ID: <20101030.121238.189687981.davem@davemloft.net> (raw)
In-Reply-To: <1288448796-6147-1-git-send-email-segooon@gmail.com>
Your patches are almost entirely baseless.
You haven't even made an effort to show a real case, in detail,
where your patches actually fix a bug. The CMSG case shows
that you didn't even bother to look at the assembly of even
one architecture to see if padding bytes even existed in the
structure, and that furthermore even if they existed that they
would leak out ever.
I don't even buy the "preventative nature" argument for the
address[128] thing. If a protocol is leaking kernel memory in that
case, it also isn't filling in the address value properly, which is a
bug times two.
I absolutely am not applying these patches, sorry.
prev parent reply other threads:[~2010-10-30 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-30 14:26 [PATCH] net: core: scm: fix information leak to userland Vasiliy Kulikov
2010-10-30 14:33 ` Eric Dumazet
2010-10-30 14:50 ` Vasiliy Kulikov
2010-10-30 19:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101030.121238.189687981.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=segooon@gmail.com \
--cc=serge@hallyn.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).