* [PATCH 1/2] vmxnet3: remove unnecessary byteswapping in BAR writing macros
@ 2010-10-28 3:12 Harvey Harrison
2010-10-28 3:12 ` [PATCH 2/2] vmxnet: trivial annotation of protocol constant Harvey Harrison
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Harvey Harrison @ 2010-10-28 3:12 UTC (permalink / raw)
To: sbhatewara; +Cc: netdev
readl/writel swap to little-endian internally.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
drivers/net/vmxnet3/vmxnet3_int.h | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h
index 8a2f471..edf2288 100644
--- a/drivers/net/vmxnet3/vmxnet3_int.h
+++ b/drivers/net/vmxnet3/vmxnet3_int.h
@@ -330,14 +330,14 @@ struct vmxnet3_adapter {
};
#define VMXNET3_WRITE_BAR0_REG(adapter, reg, val) \
- writel(cpu_to_le32(val), (adapter)->hw_addr0 + (reg))
+ writel((val), (adapter)->hw_addr0 + (reg))
#define VMXNET3_READ_BAR0_REG(adapter, reg) \
- le32_to_cpu(readl((adapter)->hw_addr0 + (reg)))
+ readl((adapter)->hw_addr0 + (reg))
#define VMXNET3_WRITE_BAR1_REG(adapter, reg, val) \
- writel(cpu_to_le32(val), (adapter)->hw_addr1 + (reg))
+ writel((val), (adapter)->hw_addr1 + (reg))
#define VMXNET3_READ_BAR1_REG(adapter, reg) \
- le32_to_cpu(readl((adapter)->hw_addr1 + (reg)))
+ readl((adapter)->hw_addr1 + (reg))
#define VMXNET3_WAKE_QUEUE_THRESHOLD(tq) (5)
#define VMXNET3_RX_ALLOC_THRESHOLD(rq, ring_idx, adapter) \
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] vmxnet: trivial annotation of protocol constant
2010-10-28 3:12 [PATCH 1/2] vmxnet3: remove unnecessary byteswapping in BAR writing macros Harvey Harrison
@ 2010-10-28 3:12 ` Harvey Harrison
2010-10-29 18:20 ` Shreyas Bhatewara
2010-10-30 23:19 ` David Miller
2010-10-29 18:17 ` [PATCH 1/2] vmxnet3: remove unnecessary byteswapping in BAR writing macros Shreyas Bhatewara
2010-10-30 23:19 ` David Miller
2 siblings, 2 replies; 6+ messages in thread
From: Harvey Harrison @ 2010-10-28 3:12 UTC (permalink / raw)
To: sbhatewara; +Cc: netdev
Noticed by sparse:
drivers/net/vmxnet3/vmxnet3_drv.c:876:38: warning: cast from restricted __be16
drivers/net/vmxnet3/vmxnet3_drv.c:876:38: warning: cast from restricted __be16
drivers/net/vmxnet3/vmxnet3_drv.c:876:24: warning: restricted __be16 degrades to integer
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
drivers/net/vmxnet3/vmxnet3_drv.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index e3658e1..21314e0 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -873,7 +873,7 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct vmxnet3_tx_queue *tq,
count = VMXNET3_TXD_NEEDED(skb_headlen(skb)) +
skb_shinfo(skb)->nr_frags + 1;
- ctx.ipv4 = (skb->protocol == __constant_ntohs(ETH_P_IP));
+ ctx.ipv4 = (skb->protocol == cpu_to_be16(ETH_P_IP));
ctx.mss = skb_shinfo(skb)->gso_size;
if (ctx.mss) {
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] vmxnet: trivial annotation of protocol constant
2010-10-28 3:12 ` [PATCH 2/2] vmxnet: trivial annotation of protocol constant Harvey Harrison
@ 2010-10-29 18:20 ` Shreyas Bhatewara
2010-10-30 23:19 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: Shreyas Bhatewara @ 2010-10-29 18:20 UTC (permalink / raw)
To: Harvey Harrison; +Cc: netdev@vger.kernel.org, pv-drivers
Thanks.
Signed-off-by: Shreyas Bhatewara <sbhatewara@vmware.com>
On Wed, 27 Oct 2010, Harvey Harrison wrote:
> Noticed by sparse:
> drivers/net/vmxnet3/vmxnet3_drv.c:876:38: warning: cast from restricted __be16
> drivers/net/vmxnet3/vmxnet3_drv.c:876:38: warning: cast from restricted __be16
> drivers/net/vmxnet3/vmxnet3_drv.c:876:24: warning: restricted __be16 degrades to integer
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> drivers/net/vmxnet3/vmxnet3_drv.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
> index e3658e1..21314e0 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -873,7 +873,7 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct vmxnet3_tx_queue *tq,
> count = VMXNET3_TXD_NEEDED(skb_headlen(skb)) +
> skb_shinfo(skb)->nr_frags + 1;
>
> - ctx.ipv4 = (skb->protocol == __constant_ntohs(ETH_P_IP));
> + ctx.ipv4 = (skb->protocol == cpu_to_be16(ETH_P_IP));
>
> ctx.mss = skb_shinfo(skb)->gso_size;
> if (ctx.mss) {
> --
> 1.7.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] vmxnet: trivial annotation of protocol constant
2010-10-28 3:12 ` [PATCH 2/2] vmxnet: trivial annotation of protocol constant Harvey Harrison
2010-10-29 18:20 ` Shreyas Bhatewara
@ 2010-10-30 23:19 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2010-10-30 23:19 UTC (permalink / raw)
To: harvey.harrison; +Cc: sbhatewara, netdev
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Wed, 27 Oct 2010 20:12:35 -0700
> Noticed by sparse:
> drivers/net/vmxnet3/vmxnet3_drv.c:876:38: warning: cast from restricted __be16
> drivers/net/vmxnet3/vmxnet3_drv.c:876:38: warning: cast from restricted __be16
> drivers/net/vmxnet3/vmxnet3_drv.c:876:24: warning: restricted __be16 degrades to integer
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] vmxnet3: remove unnecessary byteswapping in BAR writing macros
2010-10-28 3:12 [PATCH 1/2] vmxnet3: remove unnecessary byteswapping in BAR writing macros Harvey Harrison
2010-10-28 3:12 ` [PATCH 2/2] vmxnet: trivial annotation of protocol constant Harvey Harrison
@ 2010-10-29 18:17 ` Shreyas Bhatewara
2010-10-30 23:19 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: Shreyas Bhatewara @ 2010-10-29 18:17 UTC (permalink / raw)
To: Harvey Harrison; +Cc: netdev@vger.kernel.org, pv-drivers
Harvey,
Thanks for working on this. The change looks good.
Signed-off-by: Shreyas Bhatewara <sbhatewara@vmware.com>
On Wed, 27 Oct 2010, Harvey Harrison wrote:
> readl/writel swap to little-endian internally.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> drivers/net/vmxnet3/vmxnet3_int.h | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h
> index 8a2f471..edf2288 100644
> --- a/drivers/net/vmxnet3/vmxnet3_int.h
> +++ b/drivers/net/vmxnet3/vmxnet3_int.h
> @@ -330,14 +330,14 @@ struct vmxnet3_adapter {
> };
>
> #define VMXNET3_WRITE_BAR0_REG(adapter, reg, val) \
> - writel(cpu_to_le32(val), (adapter)->hw_addr0 + (reg))
> + writel((val), (adapter)->hw_addr0 + (reg))
> #define VMXNET3_READ_BAR0_REG(adapter, reg) \
> - le32_to_cpu(readl((adapter)->hw_addr0 + (reg)))
> + readl((adapter)->hw_addr0 + (reg))
>
> #define VMXNET3_WRITE_BAR1_REG(adapter, reg, val) \
> - writel(cpu_to_le32(val), (adapter)->hw_addr1 + (reg))
> + writel((val), (adapter)->hw_addr1 + (reg))
> #define VMXNET3_READ_BAR1_REG(adapter, reg) \
> - le32_to_cpu(readl((adapter)->hw_addr1 + (reg)))
> + readl((adapter)->hw_addr1 + (reg))
>
> #define VMXNET3_WAKE_QUEUE_THRESHOLD(tq) (5)
> #define VMXNET3_RX_ALLOC_THRESHOLD(rq, ring_idx, adapter) \
> --
> 1.7.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] vmxnet3: remove unnecessary byteswapping in BAR writing macros
2010-10-28 3:12 [PATCH 1/2] vmxnet3: remove unnecessary byteswapping in BAR writing macros Harvey Harrison
2010-10-28 3:12 ` [PATCH 2/2] vmxnet: trivial annotation of protocol constant Harvey Harrison
2010-10-29 18:17 ` [PATCH 1/2] vmxnet3: remove unnecessary byteswapping in BAR writing macros Shreyas Bhatewara
@ 2010-10-30 23:19 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2010-10-30 23:19 UTC (permalink / raw)
To: harvey.harrison; +Cc: sbhatewara, netdev
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Wed, 27 Oct 2010 20:12:34 -0700
> readl/writel swap to little-endian internally.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-10-30 23:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-28 3:12 [PATCH 1/2] vmxnet3: remove unnecessary byteswapping in BAR writing macros Harvey Harrison
2010-10-28 3:12 ` [PATCH 2/2] vmxnet: trivial annotation of protocol constant Harvey Harrison
2010-10-29 18:20 ` Shreyas Bhatewara
2010-10-30 23:19 ` David Miller
2010-10-29 18:17 ` [PATCH 1/2] vmxnet3: remove unnecessary byteswapping in BAR writing macros Shreyas Bhatewara
2010-10-30 23:19 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).