From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 1/2] can: pch_can: fix sparse warning Date: Sat, 30 Oct 2010 16:28:26 -0700 (PDT) Message-ID: <20101030.162826.48500988.davem@davemloft.net> References: <1288168706-870-1-git-send-email-mkl@pengutronix.de> <1288168706-870-2-git-send-email-mkl@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org Return-path: In-Reply-To: <1288168706-870-2-git-send-email-mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org From: Marc Kleine-Budde Date: Wed, 27 Oct 2010 10:38:25 +0200 > This patch fixes the following sparse warning: > > drivers/net/can/pch_can.c:231:26: warning: incorrect type in argument 1 (different address spaces) > drivers/net/can/pch_can.c:231:26: expected unsigned int [usertype] *addr > drivers/net/can/pch_can.c:231:26: got unsigned int [noderef] * > > Let pch_can_bit_{set,clear} first parameter be a void __iomem pointer. > > Signed-off-by: Marc Kleine-Budde Applied.