From: David Miller <davem@davemloft.net>
To: andy.grover@oracle.com
Cc: netdev@vger.kernel.org, rds-devel@oss.oracle.com
Subject: Re: [PATCH 0/5] RDS rds_iovec fixes
Date: Sat, 30 Oct 2010 16:34:37 -0700 (PDT) [thread overview]
Message-ID: <20101030.163437.246540203.davem@davemloft.net> (raw)
In-Reply-To: <1288316459-4679-1-git-send-email-andy.grover@oracle.com>
From: Andy Grover <andy.grover@oracle.com>
Date: Thu, 28 Oct 2010 18:40:54 -0700
> This patchset includes Linus' rds_iovec overflow fix, as well as making
> a copy of the rds_iovec array to prevent userspace from changing them after
> we've checked them.
>
> Please especially review patch 5. We go from 3 to 2 iovec copies, but it's not
> trivial to go to one, due to some code that wants to preallocate space for SGs.
> Until that code can be changed, patch 5 attempts to safely handle the scenario.
I looked carefully over these and they look ok.
Applied, thanks Andy.
prev parent reply other threads:[~2010-10-30 23:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 1:40 [PATCH 0/5] RDS rds_iovec fixes Andy Grover
2010-10-29 1:40 ` [PATCH 1/5] net: fix rds_iovec page count overflow Andy Grover
2010-10-29 1:40 ` [PATCH 2/5] RDS: Return -EINVAL if rds_rdma_pages returns an error Andy Grover
2010-10-29 1:40 ` [PATCH 3/5] RDS: Clean up error handling in rds_cmsg_rdma_args Andy Grover
2010-10-29 1:40 ` [PATCH 4/5] RDS: Copy rds_iovecs into kernel memory instead of rereading from userspace Andy Grover
2010-10-29 1:40 ` [PATCH 5/5] RDS: Let rds_message_alloc_sgs() return NULL Andy Grover
2010-10-30 23:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101030.163437.246540203.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy.grover@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).