* [PATCH] qlcnic: fix panic on load
@ 2010-10-31 15:50 Eric Dumazet
2010-10-31 16:34 ` David Miller
2010-11-01 4:58 ` Amit Salecha
0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2010-10-31 15:50 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Amit Kumar Salecha
Its now illegal to call netif_stop_queue() before register_netdev()
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Amit Kumar Salecha <amit.salecha@qlogic.com>
---
drivers/net/qlcnic/qlcnic_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/qlcnic/qlcnic_main.c b/drivers/net/qlcnic/qlcnic_main.c
index 7a298cd..a3dcd04 100644
--- a/drivers/net/qlcnic/qlcnic_main.c
+++ b/drivers/net/qlcnic/qlcnic_main.c
@@ -1450,7 +1450,6 @@ qlcnic_setup_netdev(struct qlcnic_adapter *adapter,
netdev->irq = adapter->msix_entries[0].vector;
netif_carrier_off(netdev);
- netif_stop_queue(netdev);
err = register_netdev(netdev);
if (err) {
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qlcnic: fix panic on load
2010-10-31 15:50 [PATCH] qlcnic: fix panic on load Eric Dumazet
@ 2010-10-31 16:34 ` David Miller
2010-11-01 4:58 ` Amit Salecha
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2010-10-31 16:34 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, amit.salecha
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 31 Oct 2010 16:50:38 +0100
> Its now illegal to call netif_stop_queue() before register_netdev()
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] qlcnic: fix panic on load
2010-10-31 15:50 [PATCH] qlcnic: fix panic on load Eric Dumazet
2010-10-31 16:34 ` David Miller
@ 2010-11-01 4:58 ` Amit Salecha
1 sibling, 0 replies; 3+ messages in thread
From: Amit Salecha @ 2010-11-01 4:58 UTC (permalink / raw)
To: Eric Dumazet, David Miller; +Cc: netdev
> From: Eric Dumazet [eric.dumazet@gmail.com]
> Sent: Sunday, October 31, 2010 9:20 PM
> To: David Miller
> Cc: netdev; Amit Salecha
> Subject: [PATCH] qlcnic: fix panic on load
>
> Its now illegal to call netif_stop_queue() before register_netdev()
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Amit Kumar Salecha <amit.salecha@qlogic.com>
> ---
> drivers/net/qlcnic/qlcnic_main.c | 1 -
> 1 file changed, 1 deletion(-)
Thanks Eric.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-01 4:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-31 15:50 [PATCH] qlcnic: fix panic on load Eric Dumazet
2010-10-31 16:34 ` David Miller
2010-11-01 4:58 ` Amit Salecha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).