From: David Miller <davem@davemloft.net>
To: andy.shevchenko@gmail.com
Cc: tom.leiming@gmail.com, netdev@vger.kernel.org, oliver@neukum.org,
dbrownell@users.sourceforge.net, gregkh@suse.de,
ben@decadent.org.uk, joe@perches.com, stable@kernel.org
Subject: Re: [PATCH] usbnet: fix usb_autopm_get_interface failure(v1)
Date: Mon, 01 Nov 2010 08:08:25 -0700 (PDT) [thread overview]
Message-ID: <20101101.080825.193699846.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTim_NRFV0ELzpOE6K539Wfxsw8j1eW-3TXLCrgOZ@mail.gmail.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Mon, 1 Nov 2010 17:04:35 +0200
>> + /*usbnet already took usb runtime pm, so have to enable the feature
>> + * for usb interface, otherwise usb_autopm_get_interface may return
>> + * failure if USB_SUSPEND(RUNTIME_PM) is enabled.
>> + * */
> Just minor: multiline comments doesn't follow the required style.
There were also spaces before tabs at the beginning of each
line.
I fixed all of this up when applying the patch.
prev parent reply other threads:[~2010-11-01 15:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 14:05 [PATCH] usbnet: fix usb_autopm_get_interface failure(v1) tom.leiming
2010-11-01 14:13 ` David Miller
2010-11-01 15:04 ` Andy Shevchenko
2010-11-01 15:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101101.080825.193699846.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy.shevchenko@gmail.com \
--cc=ben@decadent.org.uk \
--cc=dbrownell@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=stable@kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).