* [PATCH net-2.6 1/3] cxgb3: remove call to stop TX queues at load time.
@ 2010-11-01 20:59 Divy Le Ray
2010-11-01 20:59 ` [PATCH net-2.6 2/3] cxgb4: " Divy Le Ray
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Divy Le Ray @ 2010-11-01 20:59 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel, dm, leedom, swise
From: Divy Le Ray <divy@chelsio.com>
Remove racy queue stopping after device registration.
Signed-off-by: Divy Le Ray <divy@chelsio.com>
---
drivers/net/cxgb3/cxgb3_main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
index 407d4e2..046d846 100644
--- a/drivers/net/cxgb3/cxgb3_main.c
+++ b/drivers/net/cxgb3/cxgb3_main.c
@@ -3341,7 +3341,6 @@ static int __devinit init_one(struct pci_dev *pdev,
adapter->name = adapter->port[i]->name;
__set_bit(i, &adapter->registered_device_map);
- netif_tx_stop_all_queues(adapter->port[i]);
}
}
if (!adapter->registered_device_map) {
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH net-2.6 2/3] cxgb4: remove call to stop TX queues at load time.
2010-11-01 20:59 [PATCH net-2.6 1/3] cxgb3: remove call to stop TX queues at load time Divy Le Ray
@ 2010-11-01 20:59 ` Divy Le Ray
2010-11-01 21:10 ` David Miller
2010-11-01 20:59 ` [PATCH net-2.6 3/3] cxgb4vf: " Divy Le Ray
2010-11-01 21:10 ` [PATCH net-2.6 1/3] cxgb3: " David Miller
2 siblings, 1 reply; 6+ messages in thread
From: Divy Le Ray @ 2010-11-01 20:59 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel, dm, leedom, swise
From: Divy Le Ray <divy@chelsio.com>
Remove racy queue stopping after device registration.
Signed-off-by: Dimitris Michailidis <dm@chelsio.com>
---
drivers/net/cxgb4/cxgb4_main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/cxgb4/cxgb4_main.c b/drivers/net/cxgb4/cxgb4_main.c
index f17703f..f50bc98 100644
--- a/drivers/net/cxgb4/cxgb4_main.c
+++ b/drivers/net/cxgb4/cxgb4_main.c
@@ -3736,7 +3736,6 @@ static int __devinit init_one(struct pci_dev *pdev,
__set_bit(i, &adapter->registered_device_map);
adapter->chan_map[adap2pinfo(adapter, i)->tx_chan] = i;
- netif_tx_stop_all_queues(adapter->port[i]);
}
}
if (!adapter->registered_device_map) {
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH net-2.6 3/3] cxgb4vf: remove call to stop TX queues at load time.
2010-11-01 20:59 [PATCH net-2.6 1/3] cxgb3: remove call to stop TX queues at load time Divy Le Ray
2010-11-01 20:59 ` [PATCH net-2.6 2/3] cxgb4: " Divy Le Ray
@ 2010-11-01 20:59 ` Divy Le Ray
2010-11-01 21:10 ` David Miller
2010-11-01 21:10 ` [PATCH net-2.6 1/3] cxgb3: " David Miller
2 siblings, 1 reply; 6+ messages in thread
From: Divy Le Ray @ 2010-11-01 20:59 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel, dm, leedom, swise
From: Divy Le Ray <divy@chelsio.com>
Stopping TX queues at driver load time is not necessary.
Signed-off-by: Casey Leedom <leedom@chelsio.com>
---
drivers/net/cxgb4vf/cxgb4vf_main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/cxgb4vf/cxgb4vf_main.c b/drivers/net/cxgb4vf/cxgb4vf_main.c
index 555ecc5..6de5e2e 100644
--- a/drivers/net/cxgb4vf/cxgb4vf_main.c
+++ b/drivers/net/cxgb4vf/cxgb4vf_main.c
@@ -2600,7 +2600,6 @@ static int __devinit cxgb4vf_pci_probe(struct pci_dev *pdev,
pi->xact_addr_filt = -1;
pi->rx_offload = RX_CSO;
netif_carrier_off(netdev);
- netif_tx_stop_all_queues(netdev);
netdev->irq = pdev->irq;
netdev->features = (NETIF_F_SG | NETIF_F_TSO | NETIF_F_TSO6 |
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net-2.6 1/3] cxgb3: remove call to stop TX queues at load time.
2010-11-01 20:59 [PATCH net-2.6 1/3] cxgb3: remove call to stop TX queues at load time Divy Le Ray
2010-11-01 20:59 ` [PATCH net-2.6 2/3] cxgb4: " Divy Le Ray
2010-11-01 20:59 ` [PATCH net-2.6 3/3] cxgb4vf: " Divy Le Ray
@ 2010-11-01 21:10 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2010-11-01 21:10 UTC (permalink / raw)
To: divy; +Cc: netdev, linux-kernel, dm, leedom, swise
From: Divy Le Ray <divy@chelsio.com>
Date: Mon, 01 Nov 2010 13:59:41 -0700
> From: Divy Le Ray <divy@chelsio.com>
>
> Remove racy queue stopping after device registration.
>
> Signed-off-by: Divy Le Ray <divy@chelsio.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-11-01 21:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-01 20:59 [PATCH net-2.6 1/3] cxgb3: remove call to stop TX queues at load time Divy Le Ray
2010-11-01 20:59 ` [PATCH net-2.6 2/3] cxgb4: " Divy Le Ray
2010-11-01 21:10 ` David Miller
2010-11-01 20:59 ` [PATCH net-2.6 3/3] cxgb4vf: " Divy Le Ray
2010-11-01 21:10 ` David Miller
2010-11-01 21:10 ` [PATCH net-2.6 1/3] cxgb3: " David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).