netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net,
	Steve Glendinning <steve.glendinning@smsc.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Rasesh Mody <rmody@brocade.com>,
	Debashis Dutt <ddutt@brocade.com>,
	Kristoffer Glembo <kristoffer@gaisler.com>,
	linux-driver@qlogic.com, linux-net-drivers@solarflare.com
Subject: Re: [PATCH 0/4] Ethtool: cleanup strategy
Date: Tue, 2 Nov 2010 01:14:23 +0000	[thread overview]
Message-ID: <20101102011422.GM15074@solarflare.com> (raw)
In-Reply-To: <20101102010253.GC15848@rere.qmqm.pl>

Michał Mirosław wrote:
> On Mon, Nov 01, 2010 at 09:05:25PM +0000, Ben Hutchings wrote:
[...]
> > It also might be worth defining a standard feature flag for RX checksum
> > offload, since currently every driver has to maintain its own private
> > flag.  Though we're running short of feature flags on 32-bit machines.
> 
> RX offloads are different in that most devices allow readback of
> configured bits, so actually no specific flags are needed.
[...]

Most devices also need resetting from time to time, so those flags still
need to be included in software state.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

  reply	other threads:[~2010-11-02  1:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-31  3:40 [PATCH 0/4] Ethtool: cleanup strategy Michał Mirosław
2010-10-30  4:27 ` [PATCH 1/4] Ethtool: Introduce hw_features field in struct netdevice Michał Mirosław
2010-10-30  4:28 ` [PATCH 2/4] Ethtool: convert get_sg/set_sg calls to hw_features flag Michał Mirosław
2010-11-01 21:15   ` Ben Hutchings
2010-11-02  0:59     ` Michał Mirosław
2010-11-02  2:24   ` Matt Carlson
2010-11-03 22:29     ` Micha?? Miros??aw
2010-11-03 22:42       ` Matt Carlson
2010-11-03 22:58         ` Michał Mirosław
2010-10-30  8:44 ` [PATCH 3/4] Ethtool: convert get_tso/set_tso calls to hw_features flags Michał Mirosław
2010-11-01 21:25   ` Ben Hutchings
2010-11-02  1:14     ` Michał Mirosław
2010-11-02  2:49   ` Matt Carlson
2010-10-31  0:09 ` [PATCH 4/4] Ethtool: convert get_tx_csum/set_tx_csum " Michał Mirosław
2010-11-01 21:38   ` Ben Hutchings
2010-11-02  1:23     ` Michał Mirosław
2010-10-31  4:18 ` [PATCH 0/4] Ethtool: cleanup strategy David Miller
2010-10-31  4:30   ` Michał Mirosław
2010-11-01 21:05 ` Ben Hutchings
2010-11-02  1:02   ` Michał Mirosław
2010-11-02  1:14     ` Ben Hutchings [this message]
2010-11-02  1:30       ` Michał Mirosław

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101102011422.GM15074@solarflare.com \
    --to=bhutchings@solarflare.com \
    --cc=ddutt@brocade.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=gregkh@suse.de \
    --cc=kristoffer@gaisler.com \
    --cc=linux-driver@qlogic.com \
    --cc=linux-net-drivers@solarflare.com \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=netdev@vger.kernel.org \
    --cc=rmody@brocade.com \
    --cc=steve.glendinning@smsc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).