From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH] classifier: report statistics for basic classifier
Date: Thu, 4 Nov 2010 17:47:04 -0400 [thread overview]
Message-ID: <20101104174704.573c52e4@s6510> (raw)
The basic classifier keeps statistics but does not report it to user space.
This showed up when using basic classifier (with police) as a default catch
all on ingress; no statistics were reported.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
I consider this a bug and should go into net-2.6 but not stable.
net/sched/cls_basic.c | 4 ++++
1 file changed, 4 insertions(+)
--- a/net/sched/cls_basic.c 2010-11-04 16:06:19.984953193 -0400
+++ b/net/sched/cls_basic.c 2010-11-04 16:06:42.248953192 -0400
@@ -268,6 +268,10 @@ static int basic_dump(struct tcf_proto *
goto nla_put_failure;
nla_nest_end(skb, nest);
+
+ if (tcf_exts_dump_stats(skb, &f->exts, &basic_ext_map) < 0)
+ goto nla_put_failure;
+
return skb->len;
nla_put_failure:
next reply other threads:[~2010-11-04 21:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-04 21:47 Stephen Hemminger [this message]
2010-11-08 20:18 ` [PATCH] classifier: report statistics for basic classifier David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101104174704.573c52e4@s6510 \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).