netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Flavio Leitner <fleitner@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, herbert@gondor.hengli.com.au
Subject: Re: [PATCH] net: reset gso header when the copied skb is linearized
Date: Thu, 4 Nov 2010 18:35:27 -0200	[thread overview]
Message-ID: <20101104203527.GA21935@redhat.com> (raw)
In-Reply-To: <20101026.122801.52191238.davem@davemloft.net>

On Tue, Oct 26, 2010 at 12:28:01PM -0700, David Miller wrote:
> From: Flavio Leitner <fleitner@redhat.com>
> Date: Tue, 26 Oct 2010 17:25:11 -0200
> 
> > If I understand that correctly, the gso_segs is the number
> > of GSO segments which are divided in non-linear way. When the
> > copy is made using that function, the skb turns into a big
> > one segment inlined. So, the idea of segments is lost and
> > I'm not seeing how it is going to be divided again. 
> > Later the NIC drives does, for example:
> 
> GSO has nothing to do with linearity, although it just so happens
> to be that GSO packets tend to be non-linear due to the way
> TCP builds such frames.
> 
> The GSO segment count is the number of MSS sized frames are
> contained inside of a larger than MSS sized SKB.
> 
> That is it.  So the definition and meaning is independent of
> linearity.
> 
> Thus, if we linearize a larger than MSS sized frame, it should still
> have the same GSO attributes.

It makes sense, thanks for the explanation.
Please ignore the proposed patch.

thanks again,
-- 
Flavio

      parent reply	other threads:[~2010-11-04 20:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-25 22:23 [PATCH] net: reset gso header when the copied skb is linearized Flavio Leitner
2010-10-26 18:31 ` David Miller
2010-10-26 19:25   ` Flavio Leitner
2010-10-26 19:28     ` David Miller
2010-10-26 19:38       ` Herbert Xu
2010-11-04 20:35       ` Flavio Leitner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101104203527.GA21935@redhat.com \
    --to=fleitner@redhat.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.hengli.com.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).