public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@infradead.org>
To: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Cc: Eric Dumazet <eric.dumazet@gmail.com>, netdev@vger.kernel.org
Subject: Re: ping -I eth1 ....
Date: Fri, 5 Nov 2010 10:25:10 -0400	[thread overview]
Message-ID: <20101105142510.GA14986@canuck.infradead.org> (raw)
In-Reply-To: <OF22F5901E.A7276220-ONC12577D2.004C79CB-C12577D2.004D1571@transmode.se>

On Fri, Nov 05, 2010 at 03:01:57PM +0100, Joakim Tjernlund wrote:
> > > Then I do ifconfig eth1 down
> > > and I still see the same. Should not
> > > sendto and/or revcfrom return some error as
> > > the interface is down?
> >
> > Hmm, this reminds me one patch, yes...
> >
> > Search for " ipv4: remove all rt cache entries on UNREGISTER event"
> >
> > http://permalink.gmane.org/gmane.linux.network/173391
> 
> Ah, that does the trick. A few comments though:
> 
> 1) I think you should include IFF_RUNNING too

Probably even better to base it on the operational state of the link

netif_running() && netif_oper_up() && netif_carrier_ok() && !netif_dormant()

  reply	other threads:[~2010-11-05 14:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-05 13:14 ping -I eth1 Joakim Tjernlund
2010-11-05 13:36 ` Eric Dumazet
2010-11-05 14:01   ` Joakim Tjernlund
2010-11-05 14:25     ` Thomas Graf [this message]
2010-11-05 14:34       ` Eric Dumazet
2010-11-05 14:53         ` Thomas Graf
2010-11-05 15:04           ` Joakim Tjernlund
2010-11-05 15:45           ` Joakim Tjernlund
2010-11-05 14:57         ` Joakim Tjernlund
2010-11-05 15:06           ` Eric Dumazet
2010-11-05 15:54             ` Joakim Tjernlund
2010-11-05 20:31               ` Thomas Graf
2010-11-06  9:42                 ` Joakim Tjernlund
     [not found]                 ` <OF921B3329.67FE598A-ONC12577D3.0033387A-C12577D3.00355AC4@LocalDomain>
2010-11-09 19:33                   ` Joakim Tjernlund
     [not found]                   ` <OFC0986D69.B0E22D17-ONC12577D6.006B4A38-C12577D6.006B72F9@LocalDomain>
2010-11-17  9:29                     ` Joakim Tjernlund
2010-11-17  9:51                       ` Eric Dumazet
2010-11-17 10:09                         ` Joakim Tjernlund
2010-11-17 10:23                           ` Eric Dumazet
2010-11-17 14:03                             ` Joakim Tjernlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101105142510.GA14986@canuck.infradead.org \
    --to=tgraf@infradead.org \
    --cc=eric.dumazet@gmail.com \
    --cc=joakim.tjernlund@transmode.se \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox