* [PATCH 1/2] solos: Add 'Firmware' attribute for Traverse overall firmware version
@ 2010-11-01 20:34 David Woodhouse
2010-11-01 20:49 ` Stephen Hemminger
2010-11-08 20:18 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: David Woodhouse @ 2010-11-01 20:34 UTC (permalink / raw)
To: davem, netdev
The existing 'FirmwareVersion' attribute only covers the DSP firmware as
provided by Conexant; not the overall version of the device firmware. We
do want to be able to see the full version number too.
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
---
drivers/atm/solos-attrlist.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/atm/solos-attrlist.c b/drivers/atm/solos-attrlist.c
index 1a9332e..9a676ee 100644
--- a/drivers/atm/solos-attrlist.c
+++ b/drivers/atm/solos-attrlist.c
@@ -1,6 +1,7 @@
SOLOS_ATTR_RO(DriverVersion)
SOLOS_ATTR_RO(APIVersion)
SOLOS_ATTR_RO(FirmwareVersion)
+SOLOS_ATTR_RO(Version)
// SOLOS_ATTR_RO(DspVersion)
// SOLOS_ATTR_RO(CommonHandshake)
SOLOS_ATTR_RO(Connected)
--
1.7.3.1
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] solos: Add 'Firmware' attribute for Traverse overall firmware version
2010-11-01 20:34 [PATCH 1/2] solos: Add 'Firmware' attribute for Traverse overall firmware version David Woodhouse
@ 2010-11-01 20:49 ` Stephen Hemminger
2010-11-01 20:50 ` David Woodhouse
2010-11-08 20:18 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2010-11-01 20:49 UTC (permalink / raw)
To: David Woodhouse; +Cc: davem, netdev
On Mon, 01 Nov 2010 16:34:29 -0400
David Woodhouse <dwmw2@infradead.org> wrote:
> The existing 'FirmwareVersion' attribute only covers the DSP firmware as
> provided by Conexant; not the overall version of the device firmware. We
> do want to be able to see the full version number too.
>
> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
> ---
> drivers/atm/solos-attrlist.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/atm/solos-attrlist.c b/drivers/atm/solos-attrlist.c
> index 1a9332e..9a676ee 100644
> --- a/drivers/atm/solos-attrlist.c
> +++ b/drivers/atm/solos-attrlist.c
> @@ -1,6 +1,7 @@
> SOLOS_ATTR_RO(DriverVersion)
> SOLOS_ATTR_RO(APIVersion)
> SOLOS_ATTR_RO(FirmwareVersion)
> +SOLOS_ATTR_RO(Version)
> // SOLOS_ATTR_RO(DspVersion)
> // SOLOS_ATTR_RO(CommonHandshake)
> SOLOS_ATTR_RO(Connected)
There is a firware version in ethtool, does this driver supply it?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] solos: Add 'Firmware' attribute for Traverse overall firmware version
2010-11-01 20:34 [PATCH 1/2] solos: Add 'Firmware' attribute for Traverse overall firmware version David Woodhouse
2010-11-01 20:49 ` Stephen Hemminger
@ 2010-11-08 20:18 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2010-11-08 20:18 UTC (permalink / raw)
To: dwmw2; +Cc: netdev
From: David Woodhouse <dwmw2@infradead.org>
Date: Mon, 01 Nov 2010 16:34:29 -0400
> The existing 'FirmwareVersion' attribute only covers the DSP firmware as
> provided by Conexant; not the overall version of the device firmware. We
> do want to be able to see the full version number too.
>
> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-08 20:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-01 20:34 [PATCH 1/2] solos: Add 'Firmware' attribute for Traverse overall firmware version David Woodhouse
2010-11-01 20:49 ` Stephen Hemminger
2010-11-01 20:50 ` David Woodhouse
2010-11-08 20:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).