* [PATCH] classifier: report statistics for basic classifier
@ 2010-11-04 21:47 Stephen Hemminger
2010-11-08 20:18 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2010-11-04 21:47 UTC (permalink / raw)
To: David Miller; +Cc: netdev
The basic classifier keeps statistics but does not report it to user space.
This showed up when using basic classifier (with police) as a default catch
all on ingress; no statistics were reported.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
I consider this a bug and should go into net-2.6 but not stable.
net/sched/cls_basic.c | 4 ++++
1 file changed, 4 insertions(+)
--- a/net/sched/cls_basic.c 2010-11-04 16:06:19.984953193 -0400
+++ b/net/sched/cls_basic.c 2010-11-04 16:06:42.248953192 -0400
@@ -268,6 +268,10 @@ static int basic_dump(struct tcf_proto *
goto nla_put_failure;
nla_nest_end(skb, nest);
+
+ if (tcf_exts_dump_stats(skb, &f->exts, &basic_ext_map) < 0)
+ goto nla_put_failure;
+
return skb->len;
nla_put_failure:
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] classifier: report statistics for basic classifier
2010-11-04 21:47 [PATCH] classifier: report statistics for basic classifier Stephen Hemminger
@ 2010-11-08 20:18 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-11-08 20:18 UTC (permalink / raw)
To: shemminger; +Cc: netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Thu, 4 Nov 2010 17:47:04 -0400
> The basic classifier keeps statistics but does not report it to user space.
> This showed up when using basic classifier (with police) as a default catch
> all on ingress; no statistics were reported.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-08 20:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-04 21:47 [PATCH] classifier: report statistics for basic classifier Stephen Hemminger
2010-11-08 20:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).