From: David Miller <davem@davemloft.net>
To: jesse@nicira.com
Cc: stable@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.36 stable] vlan: Avoid hwaccel vlan packets when vid not used.
Date: Mon, 08 Nov 2010 13:26:36 -0800 (PST) [thread overview]
Message-ID: <20101108.132636.246537518.davem@davemloft.net> (raw)
In-Reply-To: <1289251381-6671-1-git-send-email-jesse@nicira.com>
From: Jesse Gross <jesse@nicira.com>
Date: Mon, 8 Nov 2010 13:23:01 -0800
> Normally hardware accelerated vlan packets are quickly dropped if
> there is no corresponding vlan device configured. The one exception
> is promiscuous mode, where we allow all of these packets through so
> they can be picked up by tcpdump. However, this behavior causes a
> crash if we actually try to receive these packets. This fixes that
> crash by ignoring packets with vids not corresponding to a configured
> device in the vlan hwaccel routines and then dropping them before they
> get to consumers in the network stack.
>
> This patch applies only to 2.6.36 stable. The problem was introduced
> in that release and is already fixed by larger changes to the vlan
> code in 2.6.37.
>
> Reported-by: Ben Greear <greearb@candelatech.com>
> Tested-by: Nikola Ciprich <extmaillist@linuxbox.cz>
> Signed-off-by: Jesse Gross <jesse@nicira.com>
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2010-11-08 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-08 21:23 [PATCH 2.6.36 stable] vlan: Avoid hwaccel vlan packets when vid not used Jesse Gross
2010-11-08 21:26 ` David Miller [this message]
2010-12-07 19:50 ` [stable] " Greg KH
2010-12-07 20:50 ` Eric Dumazet
2010-12-07 21:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108.132636.246537518.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).